Implement some changes based on parent branch PR review #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds two new interfaces: - `ClockInterface` This is basically the spec from https://github.com/php-fig/fig-standards/blob/master/proposed/clock.md except without a return typehint to support PHP 5.6 for now - `ClockAwareInterface` - this may not be necessary but it seemed reasonable to have a `getClock(): ClockInterface` contract, given that we expect to be able to get a clock in both `AccessToken` and `AbstractProvider`. This also removes some methods added in thephpleague#852, specifically: - `AccessToken::setTimeNow()` - `AccessToken::getTimeNow()` - `AccessToken::resetTimeNow()` - `AccessToken::$timeNow` That technically represents a BC break, but: 1. That code has not existed for very long and likely has very little usage. 2. This *should* only break test code unless someone was doing something very strange in production. For the existing `AccessTokenInterface`: - remove the `setClock()` and `getTimeNow()` - `getTimeNow()` is no longer needed anyway - `setClock()` better not to have a setter on an interface in this case - both of these changes were BC breaks so they were removed I believe the rest of the changes here are just cleaning up tests that used the older static method of setting the current time. The previous hack `tearDownForBackwardsCompatibility()` is no longer needed so it was removed.
kevinquinnyo
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement some requested changes from the parent branch's PR. I went ahead and took a stab at this based on this your comment here @dpi: thephpleague#866 (comment)
This adds two new interfaces:
ClockInterfaceThis is basically the spec from https://github.com/php-fig/fig-standards/blob/master/proposed/clock.md except without a return typehint to support PHP 5.6 for nowClockAwareInterface- this may not be necessary but it seemed reasonable to have agetClock(): ClockInterfacecontract, given that we expect to be able to get a clock in bothAccessTokenandAbstractProvider.This also removes some methods added in thephpleague#852, specifically:
-
AccessToken::setTimeNow()-
AccessToken::getTimeNow()-
AccessToken::resetTimeNow()-
AccessToken::$timeNowThat technically represents a BC break, but:
For the existing
AccessTokenInterface:- remove the
setClock()andgetTimeNow()-
getTimeNow()is no longer needed anyway-
setClock()better not to have a setter on an interface inthis case
- both of these changes were BC breaks so they were removed
I believe the rest of the changes here are just cleaning up tests that used the older static method of setting the current time. The previous hack
tearDownForBackwardsCompatibility()is no longer needed so it was removed.