Add the optional compression libs to extras_require #2123
Conversation
As noted in https://kafka-python.readthedocs.io/en/master/install.html these are some additional optional libs that we should be specifying in `extras_require` so that callers can specify them if desired.
| extras_require={ | ||
| "crc32c": ["crc32c"], | ||
| "lz4": ["lz4"], | ||
| "snappy": ["python-snappy"], |
There was a problem hiding this comment.
I wasn't sure if we should take the "snappy" namespace or use "python-snappy" so as to disambiguate between different implementations if we later have support for a pure-python vs c-based lib... this applies to the "zstd" entry as well...
There was a problem hiding this comment.
@dpkp @tvoinarovskyi any opinion?
There was a problem hiding this comment.
I think dropping the python- prefix is fine here.
jeffwidman
changed the title
| extras_require={ | ||
| "crc32c": ["crc32c"], | ||
| "lz4": ["lz4"], | ||
| "snappy": ["python-snappy"], |
There was a problem hiding this comment.
I think dropping the python- prefix is fine here.
| "crc32c": ["crc32c"], | ||
| "lz4": ["lz4"], | ||
| "snappy": ["python-snappy"], | ||
| "zstd": ["python-zstandard"], |
There was a problem hiding this comment.
Is this actually correct? It looks like the PyPI package is just zstandard. When testing installing only this package locally, I get an error:
$ pip install python-zstandard
ERROR: Could not find a version that satisfies the requirement python-zstandard (from versions: none)
ERROR: No matching distribution found for python-zstandard
There was a problem hiding this comment.
Seeing the same error after cloning repository and trying to install with the extra locally.
$ pip install -e .[zstd]
Obtaining file:///Users/anton/projects/kafka-python
Preparing metadata (setup.py) ... done
ERROR: Could not find a version that satisfies the requirement python-zstandard; extra == "zstd" (from kafka-python[zstd]) (from versions: none)
ERROR: No matching distribution found for python-zstandard; extra == "zstd"
There was a problem hiding this comment.
You'd be better off opening a new issue, as comments on old PR's tend to get lost.
As noted in https://kafka-python.readthedocs.io/en/master/install.html these are some additional optional libs that we should be specifying in
extras_requireso that callers can specify them if desired.Fix #2122.
This change is