Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deployments #81

Merged
merged 7 commits into from
Dec 20, 2024
Merged

Fix deployments #81

merged 7 commits into from
Dec 20, 2024

Conversation

mdellabitta
Copy link
Contributor

@mdellabitta mdellabitta commented Dec 20, 2024

Important

Update deployment workflows to use specific action versions, set environments, and add Sentry release step.

  • Environment and Runner:
    • Change runs-on to ubuntu-22.04 in both deploy-staging.yml and deploy.yml.
    • Set environment to staging in deploy-staging.yml and production in deploy.yml.
  • Action Versions:
    • Update actions/checkout to v4.
    • Update aws-actions/configure-aws-credentials to a specific commit e3dd6a4.
    • Update aws-actions/amazon-ecr-login to a specific commit 062b18b.
    • Update actions/setup-java to v4 with temurin distribution and sbt cache.
    • Update docker/setup-qemu-action to a specific commit 49b3bc8.
    • Update docker/setup-buildx-action to a specific commit 6524bf6.
  • Sentry Integration:
    • Add Sentry release step using getsentry/action-release with environment set to staging in deploy-staging.yml and production in deploy.yml.

This description was created by Ellipsis for 1e1c8e3. It will automatically update as commits are pushed.

Copy link

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 1e1c8e3 in 15 seconds

More details
  • Looked at 139 lines of code in 2 files
  • Skipped 0 files when reviewing.
  • Skipped posting 2 drafted comments based on config settings.
1. .github/workflows/deploy-staging.yml:13
  • Draft comment:
    Using a specific commit SHA for actions is good for consistency but requires regular updates to avoid security risks.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The PR updates the GitHub Actions workflow files to use specific commit SHAs for actions instead of version tags. This is a good practice for ensuring consistency and avoiding unexpected changes. However, it also means that updates to these actions won't be automatically picked up, which could be a security risk if there are vulnerabilities in the actions. It's important to regularly review and update these SHAs to the latest versions.
2. .github/workflows/deploy.yml:14
  • Draft comment:
    Using a specific commit SHA for actions is good for consistency but requires regular updates to avoid security risks.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The PR updates the GitHub Actions workflow files to use specific commit SHAs for actions instead of version tags. This is a good practice for ensuring consistency and avoiding unexpected changes. However, it also means that updates to these actions won't be automatically picked up, which could be a security risk if there are vulnerabilities in the actions. It's important to regularly review and update these SHAs to the latest versions.

Workflow ID: wflow_dvusqF1yVv3k64UN


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Copy link

codacy-production bot commented Dec 20, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: -1.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (e304fc3) 2369 1962 82.82%
Head commit (938e308) 2369 (+0) 1962 (+0) 82.82% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#81) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@mdellabitta mdellabitta merged commit fb9aebe into main Dec 20, 2024
5 checks passed
@mdellabitta mdellabitta deleted the fix-deployments branch December 20, 2024 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant