-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix deployments #81
Fix deployments #81
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Reviewed everything up to 1e1c8e3 in 15 seconds
More details
- Looked at
139
lines of code in2
files - Skipped
0
files when reviewing. - Skipped posting
2
drafted comments based on config settings.
1. .github/workflows/deploy-staging.yml:13
- Draft comment:
Using a specific commit SHA for actions is good for consistency but requires regular updates to avoid security risks. - Reason this comment was not posted:
Confidence changes required:50%
The PR updates the GitHub Actions workflow files to use specific commit SHAs for actions instead of version tags. This is a good practice for ensuring consistency and avoiding unexpected changes. However, it also means that updates to these actions won't be automatically picked up, which could be a security risk if there are vulnerabilities in the actions. It's important to regularly review and update these SHAs to the latest versions.
2. .github/workflows/deploy.yml:14
- Draft comment:
Using a specific commit SHA for actions is good for consistency but requires regular updates to avoid security risks. - Reason this comment was not posted:
Confidence changes required:50%
The PR updates the GitHub Actions workflow files to use specific commit SHAs for actions instead of version tags. This is a good practice for ensuring consistency and avoiding unexpected changes. However, it also means that updates to these actions won't be automatically picked up, which could be a security risk if there are vulnerabilities in the actions. It's important to regularly review and update these SHAs to the latest versions.
Workflow ID: wflow_dvusqF1yVv3k64UN
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more |
Important
Update deployment workflows to use specific action versions, set environments, and add Sentry release step.
runs-on
toubuntu-22.04
in bothdeploy-staging.yml
anddeploy.yml
.environment
tostaging
indeploy-staging.yml
andproduction
indeploy.yml
.actions/checkout
tov4
.aws-actions/configure-aws-credentials
to a specific commite3dd6a4
.aws-actions/amazon-ecr-login
to a specific commit062b18b
.actions/setup-java
tov4
withtemurin
distribution andsbt
cache.docker/setup-qemu-action
to a specific commit49b3bc8
.docker/setup-buildx-action
to a specific commit6524bf6
.getsentry/action-release
with environment set tostaging
indeploy-staging.yml
andproduction
indeploy.yml
.This description was created by for 1e1c8e3. It will automatically update as commits are pushed.