Htmx v1.9.6 #3
Merged
Htmx v1.9.6 #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpraimeyuu
approved these changes
Oct 5, 2023
|
For the HX-Trigger response header I'm thinking there could either be multiple functions like let withHxTriggerMultiple (events: string list) : HttpResponseModifier =
let headerValue = String.concat ", " events
Response.withHeaders [ "HX-Trigger", headerValue ]or a discriminated union like type HxTriggerResponse =
| Events of string list
| DetailedEvents of (string * obj) list |
dpraimeyuu
reviewed
Oct 5, 2023
| @@ -100,17 +105,15 @@ module Response = | |||
| Response.withHeaders [ "HX-Retarget", TargetOption.AsString option ] | |||
|
|
|||
| // Allows you to trigger client side events, see the documentation for more info | |||
| let withHxTrigger<'T>(event: string, detail : 'T option) : HttpResponseModifier = | |||
| let withHxTrigger<'T>(triggerResponse: HxTriggerResponse) : HttpResponseModifier = | |||
dpraimeyuu
approved these changes
Oct 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Begin work on update to Htmx v1.9.6 (reference: #2)
HTMX Changelog - https://github.com/bigskysoftware/htmx/blob/master/CHANGELOG.md
Current Version - 1.8.0
New Version - 1.9.6
Attributes added:
Headers added or updated:
I may have missed a few things and some of these constructs may benefit from stronger typing. Will edit after reviews and re-reading the changelogs.