Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for typeLiteral.separatorKind.multiLine: newLine #471

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

DoctorGester
Copy link

  • I don't know if such a feature is even needed for general public
  • I don't know if any of the code is good (first time editing Rust source)

This adds support for newLine separator specifically for multiline type literals. If not specified, it will fallback to whatever is specified in typeLiteral.separatorKind (implemented poorly).

@CLAassistant
Copy link

CLAassistant commented Jan 16, 2023

CLA assistant check
All committers have signed the CLA.

@dsherret
Copy link
Member

Hey @DoctorGester, I'm sorry, but this was discussed and closed in #454

For example, this is already possible when not using semi-colons like so: https://dprint.dev/playground/#code/C4TwDgpgBAKhDOwoF4oG8CwAoKurAWAC4pEAnASwDsBzAbmzygHtgALCMkqgVwFsARpwZYAvkA/config/N4WAUABBBEA2CWA7ApgdXgEwC4AtoC4IAOABgBpwpokNlEt1s9CAmCyGAZ2QFt4BhAPaxBiTgRgBDTvGjgAvuCA/language/typescript

Are you wanting to use semi-colons, but here to not use semi-colons?

@DoctorGester
Copy link
Author

Hi, @dsherret yep exactly, I wanted semicolons in the rest of the code, but not in types since types are less ambiguous in general
Feel free to close the PR if it's not needed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants