-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add config for forced multiline named imports/exports #473
Conversation
Spent some time thinking about it, and I feel like it shouldn't be a boolean, but two options, one which allows |
I think you're right. I think it's ok to land this as a boolean for now though. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I don't see any issues :)
I made the config name shorter.
In the interest of time, let's land this one and then if you'd like you can submit a follow up PR with it not being a boolean. I think maybe something like "always" | "multiple" | "something for this being off that I can't think of... maybe just 'off' or 'lineWidth'...not sure"
.
Thanks for reviewing! (These PRs are the only Rust I've actually written, so, shocked I don't have more trouble.) |
For #453.
This just does imports/exports; I'm not totally confident in the implementation or its naming, either. I just thought I'd throw an idea out there.