Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add config for forced multiline named imports/exports #473

Merged
merged 5 commits into from
Jan 27, 2023

Conversation

jakebailey
Copy link
Contributor

For #453.

This just does imports/exports; I'm not totally confident in the implementation or its naming, either. I just thought I'd throw an idea out there.

@jakebailey
Copy link
Contributor Author

Spent some time thinking about it, and I feel like it shouldn't be a boolean, but two options, one which allows import { justOneThing } from "foo" and one which doesn't.

@dsherret
Copy link
Member

Spent some time thinking about it, and I feel like it shouldn't be a boolean, but two options, one which allows import { justOneThing } from "foo" and one which doesn't.

I think you're right. I think it's ok to land this as a boolean for now though.

@dsherret dsherret marked this pull request as ready for review January 27, 2023 22:51
@dsherret dsherret changed the title Try adding support for forced multiline import/export specifiers feat: add config for forced multiline import/export specifiers Jan 27, 2023
@dsherret dsherret changed the title feat: add config for forced multiline import/export specifiers feat: add config for forced multiline named imports/exports Jan 27, 2023
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I don't see any issues :)

I made the config name shorter.

In the interest of time, let's land this one and then if you'd like you can submit a follow up PR with it not being a boolean. I think maybe something like "always" | "multiple" | "something for this being off that I can't think of... maybe just 'off' or 'lineWidth'...not sure".

@dsherret dsherret merged commit d404219 into dprint:main Jan 27, 2023
@jakebailey
Copy link
Contributor Author

Thanks for reviewing! (These PRs are the only Rust I've actually written, so, shocked I don't have more trouble.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants