Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

terminal.ansiBrightBlack is hard to see in integrated terminal #49

Closed
seanamosw opened this issue Aug 11, 2017 · 7 comments
Closed

terminal.ansiBrightBlack is hard to see in integrated terminal #49

seanamosw opened this issue Aug 11, 2017 · 7 comments

Comments

@seanamosw
Copy link

I find it very difficult to see things in the integrated terminal using this color.

powershell too dark

@dsifford
Copy link
Member

Awaiting reply on this and then I'll fix: dracula/dracula-theme#232 (comment)

@dsifford
Copy link
Member

@seanamosw Curious what command you have running that outputs BrightBlack on background? Trying out some other colors and there's really not much better I can do than what currently exists. BrightBlack on BG is just a poor color combination.

@seanamosw
Copy link
Author

seanamosw commented Aug 11, 2017

To clarify, in the original screenshot, the hard to see text is * -Recurse -Force which is just powershell highlighting in the terminal.
This is using the powershell extension for the integrated terminal.

Some other colorful console loggers also use this color and it is very hard to see with the Dracula theme.
As a temporary workaround, I just changed the color to #808080 so it is readable, at least to me on my screen.

lighter

Comparison with Monokai in ConEmu/Cmder:
monokai

@dsifford
Copy link
Member

@seanamosw Could you try changing terminal.background to the theme's background color (#282A36) and see if that helps?

I think the issue is likely the fact that the integrated terminal background is a darkened variant of the editor's background color.

Thanks in advance!

dsifford added a commit that referenced this issue Aug 12, 2017
- Fix issue on insiders causing null colors to default to red.
- Add color for new dialog UI scopes.
- Revert terminal bg color in attempt to improve contrast.

Closes #50, #46, #49
@dsifford
Copy link
Member

Switched the bg color back to default. Hopefully that helps.

@seanamosw
Copy link
Author

Sorry I didn't get back to you sooner. Unfortunately, the improvement is marginal, if any. I'm still resorting to lightening the terminal.ansiBrightBlack color to #808080 to get readability.

I've attached some console logging output to demonastrate.
Take note of the characters [],={}

Default 2.2.0, can barely see the characters.
2.2.0

Modified terminal.ansiBrightBlack:
modified

I have not tested on another display to see if it's universally difficult to see.

@seanamosw
Copy link
Author

I thought I would add an example of what it looks in ConEmu with the Dracula ConEmu theme.

Not quite as light as my workaround, but still readable:
conemu

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants