Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UKI section offsets are hard-coded #2275

Closed
medhefgo opened this issue Mar 10, 2023 · 0 comments · Fixed by #2277
Closed

UKI section offsets are hard-coded #2275

medhefgo opened this issue Mar 10, 2023 · 0 comments · Fixed by #2277
Labels
bug Our bugs

Comments

@medhefgo
Copy link

Looking at dracut.sh I can see that dracut is still hard-coding PE section offsets despite the warning in v252 release notes. This will cause overlapping PE sections at runtime should the stub's sections grow too much (our ci has been bitten by this, which is why ukify came about). It also fails to mark the .linux section as executable (on x86 it may be run in-place if the kernel is too old). Furthermore, a future systemd release may have EFI binaries with a non-zero image base. These hard-coded offsets will result in broken images that will be refused by firmware.

You could fix all this and gain extra features by using ukify, but I guess there is a case of NIH going on.
@medhefgo medhefgo added the bug Our bugs label Mar 10, 2023
keentux added a commit to keentux/dracut that referenced this issue Mar 13, 2023
@keentux
perf[uefi]: Use dynamically uefi's sections offset
118d7ed 
Uefi section are creating by `objcopy` with hardcoded sections
offset. This commit allow to have the correct offset between
each part of the efi file, needed to create an UKI. Offsets
are simply calculated so no sections overlap, as recommended
[here](systemd/systemd@0fa2cac#commitcomment-76747223)

Fixes dracutdevs#2275

Signed-off-by: Valentin Lefebvre <valentin.lefebvre@suse.com>
keentux added a commit to keentux/dracut that referenced this issue Mar 13, 2023
@keentux
perf[uefi]: Use dynamically uefi's sections offset
281eda4 
Uefi section are creating by `objcopy` with hardcoded sections
offset. This commit allow to have the correct offset between
each part of the efi file, needed to create an UKI. Offsets
are simply calculated so no sections overlap, as recommended
here: (systemd/systemd@0fa2cac#commitcomment-76747223)

Fixes dracutdevs#2275

Signed-off-by: Valentin Lefebvre <valentin.lefebvre@suse.com>
keentux added a commit to keentux/dracut that referenced this issue Mar 13, 2023
@keentux
perf[uefi]: Use dynamically uefi's sections offset
1a68476 
* Uefi section are creating by `objcopy` with hardcoded sections
offset. This commit allow to have the correct offset between
each part of the efi file, needed to create an UKI. Offsets
are simply calculated so no sections overlap, as recommended
here: (systemd/systemd@0fa2cac#commitcomment-76747223)
* Remove EFI_SECTION_VMA_INITRD, no need anymore as initrd
section offset dynamically calculated

Fixes dracutdevs#2275

Signed-off-by: Valentin Lefebvre <valentin.lefebvre@suse.com>
keentux added a commit to keentux/dracut that referenced this issue Mar 13, 2023
@keentux
perf(dracut.sh): Use dynamically uefi's sections offset
1198300 
* Uefi section are creating by `objcopy` with hardcoded sections
offset. This commit allow to have the correct offset between
each part of the efi file, needed to create an UKI. Offsets
are simply calculated so no sections overlap, as recommended
ee https://wiki.archlinux.org/title/Unified_kernel_image#Manually
* Remove EFI_SECTION_VMA_INITRD, no need anymore as initrd
section offset dynamically calculated

Fixes dracutdevs#2275

Signed-off-by: Valentin Lefebvre <valentin.lefebvre@suse.com>
@keentux keentux mentioned this issue Mar 13, 2023
Merged
3 tasks
keentux added a commit to keentux/dracut that referenced this issue Mar 14, 2023
@keentux
fix(dracut.sh): use dynamically uefi's sections offset
23036ef 
* Uefi section are creating by `objcopy` with hardcoded sections
offset. This commit allow to have the correct offset between
each part of the efi file, needed to create an UKI. Offsets
are simply calculated so no sections overlap, as recommended
ee https://wiki.archlinux.org/title/Unified_kernel_image#Manually
* Remove EFI_SECTION_VMA_INITRD, no need anymore as initrd
section offset dynamically calculated

Fixes dracutdevs#2275

Signed-off-by: Valentin Lefebvre <valentin.lefebvre@suse.com>
keentux added a commit to keentux/dracut that referenced this issue Mar 14, 2023
@keentux
fix(dracut.sh): use dynamically uefi's sections offset
a5a8d9b 
* Uefi section are creating by `objcopy` with hardcoded sections
offset. This commit allow to have the correct offset between
each part of the efi file, needed to create an UKI. Offsets
are simply calculated so no sections overlap, as recommended
ee https://wiki.archlinux.org/title/Unified_kernel_image#Manually
* Remove EFI_SECTION_VMA_INITRD, no need anymore as initrd
section offset dynamically calculated

Fixes dracutdevs#2275

Signed-off-by: Valentin Lefebvre <valentin.lefebvre@suse.com>
keentux added a commit to keentux/dracut that referenced this issue Mar 14, 2023
@keentux
fix(dracut.sh): use dynamically uefi's sections offset
c34a839 
* Uefi section are creating by `objcopy` with hardcoded sections
offset. This commit allow to have the correct offset between
each part of the efi file, needed to create an UKI. Offsets
are simply calculated so no sections overlap, as recommended
ee https://wiki.archlinux.org/title/Unified_kernel_image#Manually
* Remove EFI_SECTION_VMA_INITRD, no need anymore as initrd
section offset dynamically calculated

Fixes dracutdevs#2275

Signed-off-by: Valentin Lefebvre <valentin.lefebvre@suse.com>
keentux added a commit to keentux/dracut that referenced this issue Mar 14, 2023
@keentux
fix(dracut.sh): use dynamically uefi's sections offset
0ee7dde 
* Uefi section are creating by `objcopy` with hardcoded sections
offset. This commit allow to have the correct offset between
each part of the efi file, needed to create an UKI. Offsets
are simply calculated so no sections overlap, as recommended
ee https://wiki.archlinux.org/title/Unified_kernel_image#Manually
* Remove EFI_SECTION_VMA_INITRD, no need anymore as initrd
section offset dynamically calculated

Fixes dracutdevs#2275

Signed-off-by: Valentin Lefebvre <valentin.lefebvre@suse.com>
keentux added a commit to keentux/dracut that referenced this issue Mar 16, 2023
@keentux
fix(dracut.sh): use dynamically uefi's sections offset
3215ae3 
* Uefi section are creating by `objcopy` with hardcoded sections
offset. This commit allow to have the correct offset between
each part of the efi file, needed to create an UKI. Offsets
are simply calculated so no sections overlap, as recommended
in  https://wiki.archlinux.org/title/Unified_kernel_image#Manually
Moreover, efi stub file's header is parsed to apply the correct
offsets according the section alignment factor.
* Remove EFI_SECTION_VMA_INITRD, no need anymore as initrd
section offset dynamically calculated

Fixes dracutdevs#2275

Signed-off-by: Valentin Lefebvre <valentin.lefebvre@suse.com>
keentux added a commit to keentux/dracut that referenced this issue Mar 16, 2023
@keentux
fix(dracut.sh): use dynamically uefi's sections offset
9672ee1 
* Uefi section are creating by `objcopy` with hardcoded sections
offset. This commit allow to have the correct offset between
each part of the efi file, needed to create an UKI. Offsets
are simply calculated so no sections overlap, as recommended
in  https://wiki.archlinux.org/title/Unified_kernel_image#Manually
Moreover, efi stub file's header is parsed to apply the correct
offsets according the section alignment factor.
* Remove EFI_SECTION_VMA_INITRD, no need anymore as initrd
section offset dynamically calculated

Fixes dracutdevs#2275

Signed-off-by: Valentin Lefebvre <valentin.lefebvre@suse.com>
keentux added a commit to keentux/dracut that referenced this issue Mar 16, 2023
@keentux
fix(dracut.sh): use dynamically uefi's sections offset
17786bd 
* Uefi section are creating by `objcopy` with hardcoded sections
offset. This commit allow to have the correct offset between
each part of the efi file, needed to create an UKI. Offsets
are simply calculated so no sections overlap, as recommended
in  https://wiki.archlinux.org/title/Unified_kernel_image#Manually
Moreover, efi stub file's header is parsed to apply the correct
offsets according the section alignment factor.
* Remove EFI_SECTION_VMA_INITRD, no need anymore as initrd
section offset dynamically calculated

Fixes dracutdevs#2275

Signed-off-by: Valentin Lefebvre <valentin.lefebvre@suse.com>
keentux added a commit to keentux/dracut that referenced this issue Mar 16, 2023
@keentux
fix(dracut.sh): use dynamically uefi's sections offset
94252ac 
* Uefi section are creating by `objcopy` with hardcoded sections
offset. This commit allow to have the correct offset between
each part of the efi file, needed to create an UKI. Offsets
are simply calculated so no sections overlap, as recommended
in  https://wiki.archlinux.org/title/Unified_kernel_image#Manually
Moreover, efi stub file's header is parsed to apply the correct
offsets according the section alignment factor.
* Remove EFI_SECTION_VMA_INITRD, no need anymore as initrd
section offset dynamically calculated

Fixes dracutdevs#2275

Signed-off-by: Valentin Lefebvre <valentin.lefebvre@suse.com>
keentux added a commit to keentux/dracut that referenced this issue Mar 16, 2023
@keentux
fix(dracut.sh): use dynamically uefi's sections offset
85ab666 
* Uefi section are creating by `objcopy` with hardcoded sections
offset. This commit allow to have the correct offset between
each part of the efi file, needed to create an UKI. Offsets
are simply calculated so no sections overlap, as recommended
in  https://wiki.archlinux.org/title/Unified_kernel_image#Manually
Moreover, efi stub file's header is parsed to apply the correct
offsets according the section alignment factor.
* Remove EFI_SECTION_VMA_INITRD, no need anymore as initrd
section offset dynamically calculated

Fixes dracutdevs#2275

Signed-off-by: Valentin Lefebvre <valentin.lefebvre@suse.com>
keentux added a commit to keentux/dracut that referenced this issue Mar 16, 2023
@keentux
fix(dracut.sh): use dynamically uefi's sections offset
98bda69 
* Uefi section are creating by `objcopy` with hardcoded sections
offset. This commit allow to have the correct offset between
each part of the efi file, needed to create an UKI. Offsets
are simply calculated so no sections overlap, as recommended
in  https://wiki.archlinux.org/title/Unified_kernel_image#Manually
Moreover, efi stub file's header is parsed to apply the correct
offsets according the section alignment factor.
* Remove EFI_SECTION_VMA_INITRD, no need anymore as initrd
section offset dynamically calculated

Fixes dracutdevs#2275

Signed-off-by: Valentin Lefebvre <valentin.lefebvre@suse.com>
johannbg pushed a commit that referenced this issue Mar 20, 2023
@keentux @johannbg
fix(dracut.sh): use dynamically uefi's sections offset
f32e95b 
* Uefi section are creating by `objcopy` with hardcoded sections
offset. This commit allow to have the correct offset between
each part of the efi file, needed to create an UKI. Offsets
are simply calculated so no sections overlap, as recommended
in  https://wiki.archlinux.org/title/Unified_kernel_image#Manually
Moreover, efi stub file's header is parsed to apply the correct
offsets according the section alignment factor.
* Remove EFI_SECTION_VMA_INITRD, no need anymore as initrd
section offset dynamically calculated

Fixes #2275

Signed-off-by: Valentin Lefebvre <valentin.lefebvre@suse.com>
@medhefgo medhefgo mentioned this issue Mar 21, 2023
Closed
keentux added a commit to keentux/dracut that referenced this issue Mar 22, 2023
@keentux
fix(dracut.sh): use dynamically uefi's sections offset
b7d4c3c 
* Uefi section are creating by `objcopy` with hardcoded sections
offset. This commit allow to have the correct offset between
each part of the efi file, needed to create an UKI. Offsets
are simply calculated so no sections overlap, as recommended
in  https://wiki.archlinux.org/title/Unified_kernel_image#Manually
Moreover, efi stub file's header is parsed to apply the correct
offsets according the section alignment factor.
* Remove EFI_SECTION_VMA_INITRD, no need anymore as initrd
section offset dynamically calculated

Fixes dracutdevs#2275

Signed-off-by: Valentin Lefebvre <valentin.lefebvre@suse.com>
aafeijoo-suse pushed a commit to aafeijoo-suse/dracut that referenced this issue Jun 15, 2023
@keentux @aafeijoo-suse
fix(dracut.sh): use dynamically uefi's sections offset
f5371ff 
* Uefi section are creating by `objcopy` with hardcoded sections
offset. This commit allow to have the correct offset between
each part of the efi file, needed to create an UKI. Offsets
are simply calculated so no sections overlap, as recommended
in  https://wiki.archlinux.org/title/Unified_kernel_image#Manually
Moreover, efi stub file's header is parsed to apply the correct
offsets according the section alignment factor.
* Remove EFI_SECTION_VMA_INITRD, no need anymore as initrd
section offset dynamically calculated

Fixes dracutdevs#2275

Signed-off-by: Valentin Lefebvre <valentin.lefebvre@suse.com>
(cherry picked from commit f32e95b)
@HanabishiRecca HanabishiRecca mentioned this issue Jul 16, 2023
Closed
pvalena pushed a commit to pvalena/dracut that referenced this issue Jul 23, 2023
@keentux @pvalena
fix(dracut.sh): use dynamically uefi's sections offset
bb669da 
* Uefi section are creating by `objcopy` with hardcoded sections
offset. This commit allow to have the correct offset between
each part of the efi file, needed to create an UKI. Offsets
are simply calculated so no sections overlap, as recommended
in  https://wiki.archlinux.org/title/Unified_kernel_image#Manually
Moreover, efi stub file's header is parsed to apply the correct
offsets according the section alignment factor.
* Remove EFI_SECTION_VMA_INITRD, no need anymore as initrd
section offset dynamically calculated

Fixes dracutdevs#2275

Signed-off-by: Valentin Lefebvre <valentin.lefebvre@suse.com>
@LaszloGombos LaszloGombos mentioned this issue Jul 15, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Our bugs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(dracut.sh): use dynamically uefi's sections offset keentux/dracut
1 participant
@medhefgo