udev-rules: make sure the hwdb with ifname renaming rules is around #1681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
modules
The stable network interface naming relies on hwdb. In one particular case actually: the Dell "idrac" interface. The systemd-udevd module actually already includes the hwdb for hostonly images, but we need it to work for non-hostonly images as well as those that don't utilize the systemd-udevd module as well. Let's make udev-rules also pull in the binary hwdb for hostonly builds. On Fedora 35 this adds 2M compressed, 11M uncompressed. That is quite some extra fat, but it's consistent with what systemd-udevd does. For non-hostonly ones, pull in only what we know we need in binary form. The extra space consumed is negligible (300B uncompressed).
johannbg
reviewed
Jan 7, 2022
There was a problem hiding this comment.
Eventually support for systemd in udev-rules will be dropped and it exclusively be used for non systemd based systems while systemd based system will use systemd-udevd instead that said it makes no sense to only include 20-net-ifname.hwdb and include all hwdb's only when the case is hostonly ( we dont add vendor paths to hostonly but I can see why you chose to do that there ) it's all or nothing situation so this PR wont work as is.
Now that does not mean that we cant solve what you are trying to achieve, it just means we need to be smarter how we approach it, which probably will require a bit larger scope to be able to achieve that.
|
This issue is being marked as stale because it has not had any recent activity. It will be closed if no further activity occurs. If this is still an issue in the latest release of Dracut and you would like to keep it open please comment on this issue within the next 7 days. Thank you for your contributions. |
|
Keeping this one open until it get's cleaned up as a part of a larger scope. |
|
This issue is being marked as stale because it has not had any recent activity. It will be closed if no further activity occurs. If this is still an issue in the latest release of Dracut and you would like to keep it open please comment on this issue within the next 7 days. Thank you for your contributions. |
|
This issue is being marked as stale because it has not had any recent activity. It will be closed if no further activity occurs. If this is still an issue in the latest release of Dracut and you would like to keep it open please comment on this issue within the next 7 days. Thank you for your contributions. |
|
This issue is being marked as stale because it has not had any recent activity. It will be closed if no further activity occurs. If this is still an issue in the latest release of Dracut and you would like to keep it open please comment on this issue within the next 7 days. Thank you for your contributions. |
|
This issue is being marked as stale because it has not had any recent activity. It will be closed if no further activity occurs. If this is still an issue in the latest release of Dracut and you would like to keep it open please comment on this issue within the next 7 days. Thank you for your contributions. |
pvalena
added a commit
to pvalena/dracut
that referenced
this pull request
Jul 23, 2023
Adding a module to install hwdb. Further extensions might make only selected part of hwdb installable, to save space. The module is not included by default. Including the module adds 2MB of compressed data (on Fedora, the file has 12MB). hwdb is needed in case of custom HW, like a keyboard/mouse or various interfaces. Original PR: dracutdevs#1681
pvalena
added a commit
to pvalena/dracut
that referenced
this pull request
Jul 23, 2023
Adding a module to install hwdb. Further extensions might make only selected part of hwdb installable, to save space. The module is not included by default. Including the module adds 2MB of compressed data (on Fedora, the file has 12MB). hwdb is needed in case of custom HW, like a keyboard/mouse or various interfaces. Original PR: dracutdevs#1681
pvalena
added a commit
to pvalena/dracut-rhel8
that referenced
this pull request
Jul 23, 2023
Adding a module to install hwdb. Further extensions might make only selected part of hwdb installable, to save space. The module is not included by default. Including the module adds 2MB of compressed data (on Fedora, the file has 12MB). hwdb is needed in case of custom HW, like a keyboard/mouse or various interfaces. Original PR: dracutdevs/dracut#1681 (Cherry-picked commit: ae2ab8c8a65c4ea4f4ad4e8c8f99d493a8f686eb) Resolves: #1968118
3 tasks
pvalena
added a commit
to pvalena/dracut
that referenced
this pull request
Jul 24, 2023
Adding a module to install hwdb. Further extensions might make only selected part of hwdb installable, to save space. The module is not included by default. Including the module adds 2MB of compressed data (on Fedora, the file has 12MB). hwdb is needed in case of custom HW, like a keyboard/mouse or various interfaces. Original PR: dracutdevs#1681
pvalena
added a commit
to pvalena/dracut-rhel8
that referenced
this pull request
Jul 24, 2023
Adding a module to install hwdb. Further extensions might make only selected part of hwdb installable, to save space. The module is not included by default. Including the module adds 2MB of compressed data (on Fedora, the file has 12MB). hwdb is needed in case of custom HW, like a keyboard/mouse or various interfaces. Original PR: dracutdevs/dracut#1681 (Cherry-picked commit: 062e739d89543a38d4b3e2cab155912bc4bf9e56) Resolves: #1968118
pvalena
added a commit
to pvalena/dracut
that referenced
this pull request
Jul 25, 2023
Adding a module to install hwdb. Further extensions might make only selected part of hwdb installable, to save space. The module is not included by default. Including the module adds 2MB of compressed data (on Fedora, the file has 12MB). hwdb is needed in case of custom HW, like a keyboard/mouse or various interfaces. Original PR: dracutdevs#1681
pvalena
added a commit
to redhat-plumbers/dracut-rhel8
that referenced
this pull request
Jul 25, 2023
Adding a module to install hwdb. Further extensions might make only selected part of hwdb installable, to save space. The module is not included by default. Including the module adds 2MB of compressed data (on Fedora, the file has 12MB). hwdb is needed in case of custom HW, like a keyboard/mouse or various interfaces. Original PR: dracutdevs/dracut#1681 (Cherry-picked commit: 062e739d89543a38d4b3e2cab155912bc4bf9e56) Resolves: #1968118
pvalena
added a commit
to pvalena/dracut-rhel9
that referenced
this pull request
Aug 22, 2023
Adding a module to install hwdb. Further extensions might make only selected part of hwdb installable, to save space. The module is not included by default. Including the module adds 2MB of compressed data (on Fedora, the file has 12MB). hwdb is needed in case of custom HW, like a keyboard/mouse or various interfaces. Original PR: dracutdevs/dracut#1681 (Cherry-picked commit: 062e739d89543a38d4b3e2cab155912bc4bf9e56) Resolves: #2233597
pvalena
added a commit
to redhat-plumbers/dracut-rhel9
that referenced
this pull request
Aug 22, 2023
Adding a module to install hwdb. Further extensions might make only selected part of hwdb installable, to save space. The module is not included by default. Including the module adds 2MB of compressed data (on Fedora, the file has 12MB). hwdb is needed in case of custom HW, like a keyboard/mouse or various interfaces. Original PR: dracutdevs/dracut#1681 (Cherry-picked commit: 062e739d89543a38d4b3e2cab155912bc4bf9e56) Resolves: #2233597
pvalena
added a commit
to pvalena/dracut
that referenced
this pull request
Sep 20, 2023
Adding a module to install hwdb. Further extensions might make only selected part of hwdb installable, to save space. The module is not included by default. Including the module adds 2MB of compressed data (on Fedora, the file has 12MB). hwdb is needed in case of custom HW, like a keyboard/mouse or various interfaces. Original PR: dracutdevs#1681
dracutng
pushed a commit
to dracutng/dracut-ng
that referenced
this pull request
Apr 8, 2024
Adding a module to install hwdb. Further extensions might make only selected part of hwdb installable, to save space. The module is not included by default. Including the module adds 2MB of compressed data (on Fedora, the file has 12MB). hwdb is needed in case of custom HW, like a keyboard/mouse or various interfaces. Original PR: dracutdevs/dracut#1681
pvalena
added a commit
to pvalena/dracut-ng
that referenced
this pull request
Apr 22, 2024
Module to install hwdb.bin. Further extensions might make only selected part of hwdb installable to save space. The module is not included by default. Including the module adds 2MB of compressed data (on Fedora, the file has 12MB). Installing hwdb.bin is needed in case of custom HW like a keyboard/mouse, or various interfaces. Original PR: dracutdevs/dracut#1681
3 tasks
pvalena
added a commit
to pvalena/dracut-ng
that referenced
this pull request
Apr 22, 2024
Module to install hwdb.bin. Further extensions might make only selected part of hwdb installable to save space. The module is not included by default. Including the module adds 2MB of compressed data (on Fedora, the file has 12MB). Installing hwdb.bin is needed in case of custom HW like a keyboard/mouse, or various interfaces. Original PR: dracutdevs/dracut#1681
pvalena
added a commit
to pvalena/dracut-ng
that referenced
this pull request
May 15, 2024
Module to install hwdb.bin. Further extensions might make only selected part of hwdb installable to save space. The module is not included by default. Including the module adds 2MB of compressed data (on Fedora, the file has 12MB). Installing hwdb.bin is needed in case of custom HW like a keyboard/mouse, or various interfaces. Original PR: dracutdevs/dracut#1681
pvalena
added a commit
to pvalena/dracut-ng
that referenced
this pull request
May 15, 2024
Module to install hwdb.bin. Further extensions might make only selected part of hwdb installable to save space. The module is not included by default. Including the module adds 2MB of compressed data (on Fedora, the file has 12MB). Installing hwdb.bin is needed in case of custom HW like a keyboard/mouse, or various interfaces. Original PR: dracutdevs/dracut#1681
pvalena
added a commit
to pvalena/dracut-fedora
that referenced
this pull request
May 15, 2024
Module to install hwdb.bin. Further extensions might make only selected part of hwdb installable to save space. The module is not included by default. Including the module adds 2MB of compressed data (on Fedora, the file has 12MB). Installing hwdb.bin is needed in case of custom HW like a keyboard/mouse, or various interfaces. Original PR: dracutdevs/dracut#1681
pvalena
added a commit
to pvalena/dracut-fedora
that referenced
this pull request
May 15, 2024
Module to install hwdb.bin. Further extensions might make only selected part of hwdb installable to save space. The module is not included by default. Including the module adds 2MB of compressed data (on Fedora, the file has 12MB). Installing hwdb.bin is needed in case of custom HW like a keyboard/mouse, or various interfaces. Original PR: dracutdevs/dracut#1681
pvalena
added a commit
to redhat-plumbers/dracut-fedora
that referenced
this pull request
May 16, 2024
Module to install hwdb.bin. Further extensions might make only selected part of hwdb installable to save space. The module is not included by default. Including the module adds 2MB of compressed data (on Fedora, the file has 12MB). Installing hwdb.bin is needed in case of custom HW like a keyboard/mouse, or various interfaces. Original PR: dracutdevs/dracut#1681
pvalena
added a commit
to pvalena/dracut-fedora
that referenced
this pull request
May 16, 2024
Module to install hwdb.bin. Further extensions might make only selected part of hwdb installable to save space. The module is not included by default. Including the module adds 2MB of compressed data (on Fedora, the file has 12MB). Installing hwdb.bin is needed in case of custom HW like a keyboard/mouse, or various interfaces. Original PR: dracutdevs/dracut#1681
pvalena
added a commit
to pvalena/dracut-fedora
that referenced
this pull request
Jun 3, 2024
Module to install hwdb.bin. Further extensions might make only selected part of hwdb installable to save space. The module is not included by default. Including the module adds 2MB of compressed data (on Fedora, the file has 12MB). Installing hwdb.bin is needed in case of custom HW like a keyboard/mouse, or various interfaces. Original PR: dracutdevs/dracut#1681
pvalena
added a commit
to pvalena/dracut-fedora
that referenced
this pull request
Jun 28, 2024
Module to install hwdb.bin. Further extensions might make only selected part of hwdb installable to save space. The module is not included by default. Including the module adds 2MB of compressed data (on Fedora, the file has 12MB). Installing hwdb.bin is needed in case of custom HW like a keyboard/mouse, or various interfaces. Original PR: dracutdevs/dracut#1681
pvalena
added a commit
to redhat-plumbers/dracut-fedora
that referenced
this pull request
Sep 16, 2024
Module to install hwdb.bin. Further extensions might make only selected part of hwdb installable to save space. The module is not included by default. Including the module adds 2MB of compressed data (on Fedora, the file has 12MB). Installing hwdb.bin is needed in case of custom HW like a keyboard/mouse, or various interfaces. Original PR: dracutdevs/dracut#1681
pvalena
added a commit
to redhat-plumbers/dracut-fedora
that referenced
this pull request
Sep 18, 2024
Module to install hwdb.bin. Further extensions might make only selected part of hwdb installable to save space. The module is not included by default. Including the module adds 2MB of compressed data (on Fedora, the file has 12MB). Installing hwdb.bin is needed in case of custom HW like a keyboard/mouse, or various interfaces. Original PR: dracutdevs/dracut#1681
pvalena
added a commit
to redhat-plumbers/dracut-rhel10
that referenced
this pull request
Oct 10, 2024
Module to install hwdb.bin. Further extensions might make only selected part of hwdb installable to save space. The module is not included by default. Including the module adds 2MB of compressed data (on Fedora, the file has 12MB). Installing hwdb.bin is needed in case of custom HW like a keyboard/mouse, or various interfaces. Original PR: dracutdevs/dracut#1681
pvalena
added a commit
to redhat-plumbers/dracut-rhel10
that referenced
this pull request
Oct 27, 2024
Module to install hwdb.bin. Further extensions might make only selected part of hwdb installable to save space. The module is not included by default. Including the module adds 2MB of compressed data (on Fedora, the file has 12MB). Installing hwdb.bin is needed in case of custom HW like a keyboard/mouse, or various interfaces. Original PR: dracutdevs/dracut#1681
pvalena
added a commit
to redhat-plumbers/dracut-rhel10
that referenced
this pull request
Oct 27, 2024
Module to install hwdb.bin. Further extensions might make only selected part of hwdb installable to save space. The module is not included by default. Including the module adds 2MB of compressed data (on Fedora, the file has 12MB). Installing hwdb.bin is needed in case of custom HW like a keyboard/mouse, or various interfaces. Original PR: dracutdevs/dracut#1681
pvalena
added a commit
to pvalena/dracut-fedora
that referenced
this pull request
Jan 20, 2025
Module to install hwdb.bin. Further extensions might make only selected part of hwdb installable to save space. The module is not included by default. Including the module adds 2MB of compressed data (on Fedora, the file has 12MB). Installing hwdb.bin is needed in case of custom HW like a keyboard/mouse, or various interfaces. Original PR: dracutdevs/dracut#1681
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
The stable network interface naming relies on hwdb. In one particular
case actually: the Dell "idrac" interface.
The systemd-udevd module actually already includes the hwdb for hostonly
images, but we need it to work for non-hostonly images as well as those
that don't utilize the systemd-udevd module as well.
Let's make udev-rules also pull in the binary hwdb for hostonly builds.
On Fedora 35 this adds 2M compressed, 11M uncompressed. That is quite
some extra fat, but it's consistent with what systemd-udevd does.
For non-hostonly ones, pull in only what we know we need in binary form.
The extra space consumed is negligible (300B uncompressed).
Checklist