-
Notifications
You must be signed in to change notification settings - Fork 400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(dracut.sh): Handle ImageBase for uefi #2285
Conversation
3e6b03f
to
d5389a1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! It looks good, only minor comments.
d5389a1
to
37cf809
Compare
* UEFI creation didn't handle the ImageBase data for the PE file generation. Create an UKI thanks a stub file with a non zero BaseImage logs some warning ans generate a bad file offset management. The efi becomes unloadable. * This commit parse the PE file header, get the data and apply the ImageBase on the objcopy command. Fixes dracutdevs#2284 Signed-off-by: Valentin Lefebvre <valentin.lefebvre@suse.com>
37cf809
to
e8e9825
Compare
This issue is being marked as stale because it has not had any recent activity. It will be closed if no further activity occurs. If this is still an issue in the latest release of Dracut and you would like to keep it open please comment on this issue within the next 7 days. Thank you for your contributions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I fail to see what this one is supposed to achieve. As mentioned in #2284 it's already fixed with #2277. And passing So, as this is just a no-op it should really be reverted. |
@medhefgo The best way to move this forward would be if you could upload a PR for the revert, so that we have an open PR for this discussion. Also PR's from non-maintainers would actually land faster than from maintainers. Thanks |
Create an UKI thanks a stub file with a non zero ImageBase logs some warning and
generate a bad file offset management:
the objcopy command. To test, A kind of stub file can be created directly with
the build on systemd project. See description of Malformed section header when creating UKI with dracut and upstream systemd-stub #2284.
Checklist
Fixes #2284