-
Notifications
You must be signed in to change notification settings - Fork 400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: update NEWS.md and AUTHORS #2509
Conversation
This issue is being marked as stale because it has not had any recent activity. It will be closed if no further activity occurs. If this is still an issue in the latest release of Dracut and you would like to keep it open please comment on this issue within the next 7 days. Thank you for your contributions. |
Otherwise LGTM. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
CC also @bdrung
A release commit without an actual release is kind of weird... and even weirder without having been approved by everyone involved. Sorry, but I'm not going to support this approach. |
Thanks @aafeijoo-suse for your feedback. Release commit has been always separate from the actual tagging (signing and release) itself (Github release tool is not able to make the release commit). Please feel free to reach out to admins to tag the commit. I see this commit nothing more than saving time for project admins, so that it is easier for project admins to tag the release. Not all tagged releases will be taken by distributions (tag 058 is such an example), and some distributions will take commits between tagged releases. |
Wow... amazing answer.
Saving what? How long does it take for an admin to click the merge button if they want to?
058 had a mistake, NEWS.md was not updated, 059 only added that correction on top. You know it and you use it as an excuse? For me what you did with this "merge commit" is just wrong. And I have nothing else to say. |
I want to take this PR as an opportunity to thank my mentor @LaszloGombos and other code reviewers especially @aafeijoo-suse who helped me to learn about the project, collaboration with git, shell scripting and Linux boot process. I hope my code contribution helps to maintain the project and helps to move Linux forward. |
Based on a commit 856e7ac. Currently upstream does not create releases. Reference PR: dracutdevs/dracut#2509 Unpacked archive: https://github.com/pvalena/dracut-fedora/tree/v60-srpm-unpacked
Based on a commit 856e7ac. Currently upstream does not create releases. Reference PR: dracutdevs/dracut#2509 Unpacked archive: https://github.com/pvalena/dracut-fedora/tree/v60-srpm-unpacked
Based on a commit 856e7ac. Currently upstream does not create releases. Reference PR: dracutdevs/dracut#2509 Unpacked archive: https://github.com/pvalena/dracut-fedora/tree/v60-srpm-unpacked
Based on a commit 856e7ac. Currently upstream does not create releases. Reference PR: dracutdevs/dracut#2509 Unpacked archive: https://github.com/pvalena/dracut-fedora/tree/v60-srpm-unpacked
Based on a commit 856e7ac. Currently upstream does not create releases. Reference PR: dracutdevs/dracut#2509 Unpacked archive: https://github.com/pvalena/dracut-fedora/tree/v60-srpm-unpacked
Based on a commit 856e7ac. Currently upstream does not create releases. Reference PR: dracutdevs/dracut#2509 Unpacked archive: https://github.com/pvalena/dracut-fedora/tree/v60-srpm-unpacked
Based on a commit 856e7ac. Currently upstream does not create releases. Reference PR: dracutdevs/dracut#2509 Unpacked archive: https://github.com/pvalena/dracut-fedora/tree/v60-srpm-unpacked
Release 60 commit generated from b2af8c8.
The commit is generated using the script from #2473