fix(dracut): don't apply aggressive strip to kernel modules #2673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryncsn
changed the title
Unlike ordinary binaries, kernel module will be unusable if stripped with "-p". Fix this by always use "-g" only. So far it didn't cause many issues since most kernels have their modules signed or compressed so this is skipped. Signed-off-by: Kairui Song <kasong@tencent.com>
|
Hi @ryncsn , the development of orginal dracut repo is stalled, the latest dracut upstream is https://github.com/dracut-ng/dracut-ng I think you can close this one and repost to dracut-ng |
Hi Dave, Thanks for the info, I'll open another PR then. I saw the last PR in this repo was 2 weeks ago and didn't notice this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unlike ordinary binaries, kernel module will be unusable if stripped with "-p". Fix this by always use "-g" only.
So far it didn't cause many issues since most kernels have their modules signed or compressed so this is skipped.
This pull request changes...
Changes
Checklist
Fixes #