Add debug code using the DEBUG label
#80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pomax
commented
Jul 29, 2024
| // problem. Similarly, native-typescript engines like Deno or Bun *do* follow | ||
| // the spec and so the following typing is correct when running in those. | ||
| private _pressHoldIntervalId?: number | undefined; | ||
| private _pressHoldIntervalId?: ReturnType<typeof setTimeout> | undefined; |
There was a problem hiding this comment.
A handy way to circumvent "this could be Node, or could be the browser, we don't know" =)
Bernardo-Castilho
approved these changes
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEBUG: ...statements in a bunch of places..gitignoreand.npmignore.min.jsfor the debug version instead, so that manual testing usingnpm startuses the debug bundletscas linter pass, with an update to the README.md for anyone who might want to help fix something in the code.Closes #79