Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding FakerDataProvider #31

Merged
merged 3 commits into from
Dec 12, 2020
Merged

adding FakerDataProvider #31

merged 3 commits into from
Dec 12, 2020

Conversation

easazade
Copy link
Contributor

@easazade easazade commented Dec 3, 2020

Connected to #30

hey @drager
I made a few changes. just adding the feature of accepting a FakerDataProvider to the Faker class.
right now FakerDataProvider only accepts a LoremDataProvider.

also added a FakerDataProviderFa which does provide farsi lorem text.
review the code if it looks ok let me know to do the same job with the other parts like address, person, etc.

@easazade
Copy link
Contributor Author

easazade commented Dec 7, 2020

Did you get a chance to look at it?

@drager
Copy link
Owner

drager commented Dec 7, 2020

Did you get a chance to look at it?

Just looked at it. Thanks! Will make sure the build passes before merging.

@drager drager merged commit af7f834 into drager:master Dec 12, 2020
@easazade
Copy link
Contributor Author

have you published it? because I don't get the last version when I include it in pubspec.yaml dependencies

@drager
Copy link
Owner

drager commented Dec 19, 2020

@easazade I have not published it just yet

@drager
Copy link
Owner

drager commented Feb 21, 2021

@easazade Published in 2.0.0-rc-1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants