Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(phone-number): implemented phone number support #34

Merged
merged 3 commits into from
Dec 18, 2020

Conversation

wim07101993
Copy link

Connection with issue(s)

Resolve issue #33

Testing and Review Notes

All previous unit tests should pass. Added a new test for generating phone numbers.

Copy link
Owner

@drager drager left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Just some thoughts below

test/specs/phone_number.dart Outdated Show resolved Hide resolved
test/specs/phone_number.dart Outdated Show resolved Hide resolved
@wim07101993 wim07101993 requested a review from drager December 17, 2020 21:44
@drager drager merged commit fd8ee51 into drager:master Dec 18, 2020
@drager drager mentioned this pull request Dec 18, 2020
@firatcetiner
Copy link

firatcetiner commented Feb 14, 2021

PhoneNumber() cannot be used in 1.3.0. @drager When do you plan to publish a new version that includes this PR? In the meantime, I will have to fetch the package from git instead of pub.

@drager
Copy link
Owner

drager commented Feb 21, 2021

@firatcetiner Please try out 2.0.0-rc-1

@firatcetiner
Copy link

firatcetiner commented Feb 27, 2021

@drager Thanks. I guess I will stick with the old version because I can not switch to the Flutter beta since 2.0.0-rc-1 requires Dart SDK version to be >=2.12.0 and the current Flutter stable channel has 2.10.5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants