Skip to content

Commit

Permalink
chore(helm): Make release pipeline to update golden files
Browse files Browse the repository at this point in the history
Golden files need to be updated as version is updated in the
`Chart.yaml` file. This commit adds the step to update the golden
files in the release pipeline.

To make that possible, The following additional changes are also
required:
- `Go.Work`: This adds support multi-module projects as we will
   have the tests along with the operator in sub-folders. This
   is required to run go cmds from the root directory. (like
   running tests in this case).
- `.helmignore`: This updates the Helm chart to ignore the `/ci`
    folder during helm packaging as those are not required for
    users of the chart.
  • Loading branch information
Pothulapati committed Mar 6, 2023
1 parent 5f92f84 commit 30dc1b3
Show file tree
Hide file tree
Showing 4 changed files with 15 additions and 3 deletions.
3 changes: 1 addition & 2 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -101,8 +101,7 @@ jobs:

- name: Chart Rendering Tests
run: |
cd contrib/charts/dragonfly
go test -v ./...
go test -v ./contrib/charts/dragonfly/...
- name: Set up chart-testing
uses: helm/chart-testing-action@v2.3.1
Expand Down
8 changes: 7 additions & 1 deletion .github/workflows/docker-release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,9 @@ jobs:
- name: Install helm
uses: azure/setup-helm@v3

- name: Setup Go
uses: actions/setup-go@v3

- name: Configure Git
if: env.IS_PRERELEASE != 'true'
run: |
Expand All @@ -85,9 +88,12 @@ jobs:
-e 's/^(appVersion\:) .*/\1 "'${{ env.TAG_NAME }}'"/g' \
contrib/charts/dragonfly/Chart.yaml
go test ./contrib/charts/dragonfly/... -update
git commit \
-m 'chore(helm-chart): update to ${{ env.TAG_NAME }}' \
contrib/charts/dragonfly/Chart.yaml
contrib/charts/dragonfly/Chart.yaml \
contrib/charts/dragonfly/ci
- name: Push Helm chart as OCI to Github
if: env.IS_PRERELEASE != 'true'
Expand Down
4 changes: 4 additions & 0 deletions contrib/charts/dragonfly/.helmignore
Original file line number Diff line number Diff line change
Expand Up @@ -21,3 +21,7 @@
.idea/
*.tmproj
.vscode/
ci/
*.go
go.mod
go.sum
3 changes: 3 additions & 0 deletions go.work
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
go 1.20

use ./contrib/charts/dragonfly

0 comments on commit 30dc1b3

Please sign in to comment.