bug(server): exit not crash when port in use (#516)

Signed-off-by: adi_holden <adi@dragonflydb.io>
dragonflydb · Nov 29, 2022 · f57bf0d · f57bf0d
1 parent 2493434
commit f57bf0d
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/helio b/helio
diff --git a/src/server/dfly_main.cc b/src/server/dfly_main.cc
@@ -186,7 +186,10 @@ bool RunEngine(ProactorPool* pool, AcceptServer* acceptor) {
 
   error_code ec = acceptor->AddListener(bind_addr, port, main_listener);
 
-  LOG_IF(FATAL, ec) << "Could not open port " << port << ", error: " << ec.message();
+  if (ec) {
+    LOG(ERROR) << "Could not open port " << port << ", error: " << ec.message();
+    exit(1);
+  }
 
   if (mc_port > 0) {
     acceptor->AddListener(mc_port, new Listener{Protocol::MEMCACHE, &service});
+1 −0		base/varz_value.h
+7 −4		cmake/third_party.cmake
+57 −38		examples/raw_echo_server.cc
+73 −0		patches/mimalloc-v2.0.5.patch
+1 −1		util/proactor_base.cc
+2 −3		util/tls/tls_engine_test.cc