Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement creation of deb package #249

Closed
romange opened this issue Aug 20, 2022 · 11 comments
Closed

implement creation of deb package #249

romange opened this issue Aug 20, 2022 · 11 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Milestone

Comments

@romange
Copy link
Collaborator

romange commented Aug 20, 2022

part of much bigger #237

a pretty extensive blog post guides on how to build debian packages. Also https://earthly.dev/blog/creating-and-hosting-your-own-deb-packages-and-apt-repo/ but it does not use cmake.

no need to host or build a repo, just to make sure we can build the deb using cpack -G DEB.
The goal at this point is to release deb via our release pipeline on github.
cmake is just one challenge. another (minor) one - installing the dragonfly will require a systemd service script.

@romange romange added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Aug 20, 2022
@romange romange added this to the Post-Release milestone Aug 22, 2022
@acheevbhagat
Copy link
Contributor

I can take a crack at this one, but I won't have time to start on it for the next 3 or 4 days

@romange
Copy link
Collaborator Author

romange commented Aug 25, 2022

thanks Acheev, much appreciated. and it's not urgent at all.

@romange
Copy link
Collaborator Author

romange commented Sep 8, 2022

hi @acheevbhagat, are you planning on working on this?

@acheevbhagat
Copy link
Contributor

Ah yes I am.
Truthfully, I forgot I had put my name on this issue. Thank you for reminding me, I am still planning on doing this.

@romange
Copy link
Collaborator Author

romange commented Sep 8, 2022

Well, now you are officially assigned 😆
I will keep reminding you from time to time ;)

acheevbhagat added a commit to acheevbhagat/dragonfly that referenced this issue Sep 11, 2022
Signed-off-by: Acheev Bhagat <acheevbhagat@hotmail.com>
acheevbhagat added a commit to acheevbhagat/dragonfly that referenced this issue Sep 12, 2022
Signed-off-by: Acheev Bhagat <acheevbhagat@hotmail.com>
@acheevbhagat
Copy link
Contributor

acheevbhagat commented Sep 12, 2022

Just wanted to drop a small update
I have created a packing.cmake file to generate the deb package, and it seemingly works installing to my vm, but I want to do some more testing and make sure it's actually working properly + learn some more about cpack to make sure I'm doing things right + create the systemd script
I have the changes on my fork if you care to check them out, and if you want me to put up a wip pr I can do that too

acheevbhagat added a commit to acheevbhagat/dragonfly that referenced this issue Sep 12, 2022
Signed-off-by: Acheev Bhagat <acheevbhagat@hotmail.com>
@romange
Copy link
Collaborator Author

romange commented Sep 12, 2022

Thanks, Acheev. I actually do not know myself how to generate the deb package, so at this point you already know better than me.
I trust you do the necessary checks. Shoot the PR afterwards! :)

acheevbhagat added a commit to acheevbhagat/dragonfly that referenced this issue Sep 18, 2022
acheevbhagat added a commit to acheevbhagat/dragonfly that referenced this issue Sep 18, 2022
acheevbhagat added a commit to acheevbhagat/dragonfly that referenced this issue Sep 18, 2022
acheevbhagat added a commit to acheevbhagat/dragonfly that referenced this issue Sep 18, 2022
acheevbhagat added a commit to acheevbhagat/dragonfly that referenced this issue Sep 18, 2022
acheevbhagat added a commit to acheevbhagat/dragonfly that referenced this issue Sep 18, 2022
acheevbhagat added a commit to acheevbhagat/dragonfly that referenced this issue Sep 18, 2022
acheevbhagat added a commit to acheevbhagat/dragonfly that referenced this issue Sep 18, 2022
acheevbhagat added a commit to acheevbhagat/dragonfly that referenced this issue Sep 20, 2022
@hwittenborn
Copy link

If you'd rather use some simple Bash scripting, makedeb could provide a quick and easy way to make the package. It's a project I'm the lead for, but it's already seen some adoption and success among some big projects.

Any thoughts?

@romange
Copy link
Collaborator Author

romange commented Oct 18, 2022

I do not know enough to say why either option is better. Currently, I just do not have time to learn the domain, waiting for the team to grow and then the task owner will decide.

@dragonflydb dragonflydb deleted a comment from antonffeksdnu Dec 28, 2022
@romange romange changed the title implement creation of deb package via cmake implement creation of deb package Jan 11, 2023
@boazsade
Copy link
Contributor

The first PR will only include the required files/scripts to generate the packages.
The second PR will include the changes to the git workflow so that we would generate a version automatically from git actions.

@boazsade
Copy link
Contributor

boazsade commented Feb 8, 2023

We now have deb packages for x86 as well as ARM

@boazsade boazsade closed this as completed Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants