Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BITPOS does not work #835

Closed
talbii opened this issue Feb 21, 2023 · 0 comments · Fixed by #907
Closed

BITPOS does not work #835

talbii opened this issue Feb 21, 2023 · 0 comments · Fixed by #907
Assignees
@chakaz
Labels
bug Something isn't working docs-fixit

Comments

@talbii
Copy link
Contributor

talbii commented Feb 21, 2023 •
edited
Loading

Currently, BITPOS has no implementation, in the sense that the command is set to always return zero.

dragonfly/src/server/bitops_family.cc

Lines 485 to 487 in f175127

void BitPos(CmdArgList args, ConnectionContext* cntx) {
(*cntx)->SendLong(0);
}

Example

> SET mykey "\xff\x00"
> BITPOS mykey 0
0

whereas it is expected to return 8.
@talbii talbii added bug Something isn't working docs-fixit labels Feb 21, 2023
chakaz pushed a commit to chakaz/dragonfly that referenced this issue Mar 4, 2023
feat(server): Implement BITPOS.
adad780 
Fixes dragonflydb#835.

Signed-off-by: chakaz <chakaz@chakaz>
@chakaz chakaz mentioned this issue Mar 4, 2023
Merged
ashotland pushed a commit that referenced this issue Mar 11, 2023
@chakaz
feat(server): Implement BITPOS. (#907)
011c086 
* feat(server): Implement BITPOS.

Fixes #835.

---------

Signed-off-by: chakaz <chakaz@chakaz>
Co-authored-by: chakaz <chakaz@chakaz>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chakaz chakaz

Labels
bug Something isn't working docs-fixit
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(server): Implement BITPOS. chakaz/dragonfly
2 participants
@chakaz @talbii