Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSON.RESP path arg should be optional #852

Closed
ashotland opened this issue Feb 21, 2023 · 4 comments · Fixed by #865
Closed

JSON.RESP path arg should be optional #852

ashotland opened this issue Feb 21, 2023 · 4 comments · Fixed by #865
Labels
bug Something isn't working docs-fixit

Comments

@ashotland
Copy link
Contributor

JSON.SET item:2 $ '{"name":"Wireless earbuds","description":"Wireless Bluetooth in-ear headphones","connection":{"wireless":true,"type":"Bluetooth"},"price":64.99,"stock":17,"colors":["black","white"], "max_level":[80, 100, 120]}'

JSON.RESP item:2
yields
(error) ERR wrong number of arguments for 'json.resp' command

should behave like JSON.RESP item:2 $

@ashotland ashotland added bug Something isn't working docs-fixit labels Feb 21, 2023
@iko1
Copy link
Contributor

iko1 commented Feb 21, 2023

I'm pretty sure that you can open the same bug on each JSON command, the path is required.

@romange
Copy link
Collaborator

romange commented Feb 21, 2023

@iko1 why are you saying this?
https://docs.aws.amazon.com/AmazonElastiCache/latest/red-ug/json-resp.html says that path is optional.

@iko1
Copy link
Contributor

iko1 commented Feb 21, 2023

Indeed, in the official documentation of both Json implementations, the path is optional.
What I'm saying is if you set the path argument to be optional and set the default value of the path to the root on one JSON command in the projects' JSON implementation, I recommend doing the same change in each Json command, to be aligned with the other JSON implementations.

@romange
Copy link
Collaborator

romange commented Feb 21, 2023

Got ya!

iko1 added a commit to iko1/dragonfly that referenced this issue Feb 21, 2023
romange pushed a commit that referenced this issue Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working docs-fixit
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants