bug(server): emulate readonly command #1004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romange
reviewed
Mar 28, 2023
src/server/server_family.cc
Outdated
| @@ -1262,6 +1264,9 @@ void ServerFamily::Cluster(CmdArgList args, ConnectionContext* cntx) { | |||
| std::string msg = BuildClusterNodeReply(cntx); | |||
| (*cntx)->SendBulkString(msg); | |||
| return; | |||
| } else if (sub_cmd == "READONLY") { | |||
| (*cntx)->SendOk(); | |||
There was a problem hiding this comment.
you have not checked with https://github.com/mediocregopher/radix that it works, have not you? :)
it does not fix the issue because this is not a subcommand. it's a separate command that exists only in cluster mode. so you need to register it conditionally only if we run in emulated mode.
There was a problem hiding this comment.
correct, have not tested with radix.
ashotland
force-pushed
the
cluster-readonly
branch
2 times, most recently
from
72fe27f to
2a78350
Compare
ashotland
changed the title
For cluster mode. Simply retun OK. Signed-off-by: ashotland <ari@dragonflydb.io>
ashotland
force-pushed
the
cluster-readonly
branch
from
2a78350 to
db72ac2
Compare
romange
reviewed
Mar 29, 2023
src/server/server_family.cc
Outdated
| @@ -42,6 +42,7 @@ extern "C" { | |||
| #include "server/tiered_storage.h" | |||
| #include "server/transaction.h" | |||
| #include "server/version.h" | |||
| #include "server_family.h" | |||
Signed-off-by: ashotland <ari@dragonflydb.io>
romange
approved these changes
Mar 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For cluster mode.
Simply return OK.
Fixes #1003