-
Notifications
You must be signed in to change notification settings - Fork 981
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(release): Also bundle dragonfly-debug builds #2424
Merged
Merged
Changes from 11 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
4c4524e
feat(release): Also bundle dragonfly-debug builds
Pothulapati 5c1dc20
remove create release to test
Pothulapati f098f6b
fix APP_PATH
Pothulapati 3d727cf
continue command
Pothulapati 78fb0c2
Merge branch 'main' into tar/debug-release
Pothulapati 9dafb9b
Merge branch 'main' into tar/debug-release
Pothulapati 48e9d8b
Merge branch 'main' into tar/debug-release
Pothulapati b49cbaa
Merge branch 'main' into tar/debug-release
Pothulapati 8e58eac
use ubuntu dev
Pothulapati d9fe2f4
don't run regression tests
Pothulapati 0f002a7
readd all the unnecessary changes
Pothulapati 098ebd9
remove whitespace changes
Pothulapati 59a47da
whitespace
Pothulapati 72ccda4
Merge branch 'main' into tar/debug-release
Pothulapati dcf827e
-debug to -dbgsym
Pothulapati File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the actual change. Essentially we are storing a -debug.tar.gz wih the dragonfly binary before its stripped of symbols and then expect the release pipeline to also publish these files.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why there is a whitespace change? Can you please remove unnecessary changes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure! Linter did its thing!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, just to make sure the naming is not misleading, I suggest that we call it
$(RELEASE_NAME)-dbgsym.tgz
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done!