feat(server): Add backlog flag for listen()
#2456
Conversation
src/server/dfly_main.cc
Outdated
| @@ -73,6 +73,8 @@ ABSL_FLAG(bool, force_epoll, false, | |||
| ABSL_FLAG(bool, version_check, true, | |||
| "If true, Will monitor for new releases on Dragonfly servers once a day."); | |||
|
|
|||
| ABSL_FLAG(uint16_t, backlog, 128, "TCP listen(2) backlog parameter."); | |||
There was a problem hiding this comment.
lets make it closer to redis name, i.e. tcp_backlog. Also clearer to what it refers.
|
Hi guys! Which version it supposed to be released? |
|
Do you use docker or binary? |
|
Binary |
|
it's gonna be released in v1.15 next month. |
|
@romange What about Docker releases? |
|
Gonna be released via https://github.com/dragonflydb/dragonfly/pkgs/container/dragonfly-weekly next week |
|
I don't see it's available as option in helm chart yet. I guess it also should increase this value in the container when we will set the param when available through helm? Current values inside container running 15.1 through helm chart. > cat /proc/sys/net/core/somaxconn
1024
> sysctl net.ipv4.tcp_max_syn_backlog
net.ipv4.tcp_max_syn_backlog = 1024At least according to redis docs:
|
|
yeah, the helm chart was not updated, our default value is 128. If you need Helm chart support feel free to open a PR |
Fixes #1643