fix(transaction): Improve ACTIVE flags management #2458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romange
reviewed
Jan 23, 2024
src/server/transaction.cc
Outdated
|
|
||
| if (multi_->mode == NON_ATOMIC) { | ||
| sd.local_mask = 0; // Non atomic transactions schedule each time, so remove all flags | ||
| sd.pq_pos = TxQueue::kEnd; // and txq pos |
There was a problem hiding this comment.
should not it be already at kEnd?
romange
reviewed
Jan 23, 2024
src/server/transaction.cc
Outdated
| } | ||
| coordinator_state_ = 0; | ||
| DCHECK_EQ(sd.is_armed.load(memory_order_relaxed), false); |
romange
previously approved these changes
Jan 23, 2024
Signed-off-by: Vladislav Oleshko <vlad@dragonflydb.io>
romange
approved these changes
Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #2457
Previously we set the ACTIVE flag on the wrong shard for non-atomic multi transactions, however we determined our activeness by the
shard_id == unique_shard_idrule, so the code was working correctly. Added a DCHECK that asserts this (yes it failed tests)I'm now explicitly clearing local_mask for atomic multi in
MultiSwitchCmdand DHCECK that it's cleared during the initialization