Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reduce test_pipeline_batching_while_migrating flakiness #2475

Merged
merged 2 commits into from
Jan 25, 2024
Merged

fix: reduce test_pipeline_batching_while_migrating flakiness #2475

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c917236
fix: reduce test_pipeline_batching_while_migrating flakiness
dranikpg Jan 25, 2024
def9d6d
fix: add comment
dranikpg Jan 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions tests/dragonfly/connection_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -534,9 +534,14 @@ async def test_pipeline_batching_while_migrating(
writer.write("INCR a\r\n".encode())
await writer.drain()

# The data doesn't necessarily arrive in a single batch
async def read():
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

care to add a comment to explain? :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a comment, it's only a suspicion so far 😅

reply = ""
while not reply.strip().endswith("51"):
reply = (await reader.read(520)).decode()

# Make sure we recived all replies
reply = await reader.read(520)
assert reply.decode().strip().endswith("51")
await asyncio.wait_for(read(), timeout=2.0)

writer.close()
await writer.wait_closed()
Expand Down
Loading