feat(cluster): add migration finalization #2507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romange
reviewed
Jan 30, 2024
romange
reviewed
Jan 30, 2024
romange
reviewed
Jan 30, 2024
adiholden
reviewed
Jan 31, 2024
adiholden
reviewed
Jan 31, 2024
BorysTheDev
force-pushed
the
add_migration_finalization
branch
from
9693a3e to
f91a123
Compare
adiholden
reviewed
Feb 1, 2024
adiholden
reviewed
Feb 1, 2024
adiholden
reviewed
Feb 1, 2024
chakaz
reviewed
Feb 1, 2024
src/server/cluster/cluster_family.cc
Outdated
Comment on lines
716
to
727
| shard_set->pool()->AwaitFiberOnAll([migration_it](auto*) { | ||
| if (const auto* shard = EngineShard::tlocal(); shard) | ||
| migration_it->second->Finalize(shard->shard_id()); | ||
| }); | ||
|
|
||
| // TODO do next after ACK | ||
| util::ThisFiber::SleepFor(500ms); | ||
|
|
||
| shard_set->pool()->AwaitFiberOnAll([migration_it](auto*) { | ||
| if (const auto* shard = EngineShard::tlocal(); shard) | ||
| migration_it->second->Cancel(shard->shard_id()); | ||
| }); |
There was a problem hiding this comment.
Suggested change
| shard_set->pool()->AwaitFiberOnAll([migration_it](auto*) { | |
| if (const auto* shard = EngineShard::tlocal(); shard) | |
| migration_it->second->Finalize(shard->shard_id()); | |
| }); | |
| // TODO do next after ACK | |
| util::ThisFiber::SleepFor(500ms); | |
| shard_set->pool()->AwaitFiberOnAll([migration_it](auto*) { | |
| if (const auto* shard = EngineShard::tlocal(); shard) | |
| migration_it->second->Cancel(shard->shard_id()); | |
| }); | |
| shard_set->pool()->AwaitFiberOnAll([migration_it](auto*) { | |
| if (const auto* shard = EngineShard::tlocal(); shard) | |
| migration_it->second->Finalize(shard->shard_id()); | |
| // TODO do next after ACK | |
| util::ThisFiber::SleepFor(500ms); | |
| migration_it->second->Cancel(shard->shard_id()); | |
| }); |
I imagine we will also wait for the ACK in each of the shards, right?
There was a problem hiding this comment.
no we will have only one ack and I think they will be here or in OutgoingMigration::Finalize
There was a problem hiding this comment.
// TODO do next after ACK
util::ThisFiber::SleepFor(500ms);
also TODO: actually stop traffic to make transition atomic 🙂
There was a problem hiding this comment.
I already in progress with that) so I will not forget about it
BorysTheDev
force-pushed
the
add_migration_finalization
branch
from
8318973 to
82c48f6
Compare
chakaz
previously approved these changes
Feb 1, 2024
dranikpg
reviewed
Feb 1, 2024
src/server/cluster/cluster_family.cc
Outdated
Comment on lines
716
to
727
| shard_set->pool()->AwaitFiberOnAll([migration_it](auto*) { | ||
| if (const auto* shard = EngineShard::tlocal(); shard) | ||
| migration_it->second->Finalize(shard->shard_id()); | ||
| }); | ||
|
|
||
| // TODO do next after ACK | ||
| util::ThisFiber::SleepFor(500ms); | ||
|
|
||
| shard_set->pool()->AwaitFiberOnAll([migration_it](auto*) { | ||
| if (const auto* shard = EngineShard::tlocal(); shard) | ||
| migration_it->second->Cancel(shard->shard_id()); | ||
| }); |
There was a problem hiding this comment.
// TODO do next after ACK
util::ThisFiber::SleepFor(500ms);
also TODO: actually stop traffic to make transition atomic 🙂
adiholden
approved these changes
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.