Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi :) Tagging @romange since I've only been speaking to you so far.
There are a few things missing in this PR, namely:
FieldExpire
is not yet implemented.I'd like some feedback on a few questions, and in general on the code:
HEXPIRE
supposed to call into the more generalFieldExpire
after modifying theCmdArgParser
, or just use the same underlying common function for manipulating field ttl?ReplaceObj
and instead useAddOrFind
since we alwaysFind
the fields before modifying their ttl?I think I also need to re-arrange the code such that I ensure the correct encoding (which supports TTL) is only enforced once for each call, and then each field is operated on afterwards. But I can't see a whole lot of code sharing between sets and hsets here, other than that they're both operating on dense_sets. I'm a c++ noob though, so feel free to correct me on this.
This PR is related to: #3027
Thanks in advance.