chore: Forbid replicating a replica #3779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We do not support connecting a replica to a replica, but before this PR we allowed doing so. This PR disables that behavior. Fixes #3679
adiholden
reviewed
Sep 24, 2024
src/server/server_family.cc
Outdated
| @@ -2839,6 +2839,10 @@ void ServerFamily::ReplTakeOver(CmdArgList args, ConnectionContext* cntx) { | |||
| } | |||
|
|
|||
| void ServerFamily::ReplConf(CmdArgList args, ConnectionContext* cntx) { | |||
| if (!ServerState::tlocal()->is_master) { | |||
There was a problem hiding this comment.
I think that this should be checked with the replicaof_mu_ locked
There was a problem hiding this comment.
Why?
It's a thread-local variable, so it can't be read non-atomically.
Also, there are many places that use it, all without that lock. Furthermore, the lock is only available in ServerFamily, while other places use it as well..?
There was a problem hiding this comment.
the is_master is eventually consistent. It can be that the server is currenly configured as a replica and did not get to set the is_master flag on this thread right?
adiholden
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We do not support connecting a replica to a replica, but before this PR we allowed doing so. This PR disables that behavior.
Fixes #3679