feat(rdb_load): add support for loading huge hmaps and zsets #3823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andydunstall
force-pushed
the
rdb-load-huge-objects
branch
from
a3150db to
be206ba
Compare
andydunstall
force-pushed
the
rdb-load-huge-objects
branch
from
be206ba to
d665a31
Compare
romange
reviewed
Sep 30, 2024
romange
reviewed
Sep 30, 2024
src/server/rdb_load.cc
Outdated
| // which is greater than server.zset_max_listpack_entries so we'll always | ||
| // use a SortedMap set not listpack. | ||
| if (pv_->ObjType() != OBJ_ZSET) { | ||
| LOG(ERROR) << "Invalid RDB type " << pv_->ObjType(); |
romange
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows #3807 to add support for loading huge hmaps and zsets (#3760)