fix(rdb_load): fix loading huge hmaps with ttl #3825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romange
reviewed
Sep 29, 2024
src/server/rdb_load.cc
Outdated
| size_t n = len; | ||
| if (n > kMaxBlobLen) { | ||
| // Ensure n is a multiple of increment. | ||
| n = kMaxBlobLen - (kMaxBlobLen % increment); |
There was a problem hiding this comment.
Lets define kMaxBlobLen be a multiple of 6 with a comment why it's needed.
andydunstall
force-pushed
the
fix-load-hmap-with-ttl
branch
from
3b5ac1d to
e1f0fdb
Compare
romange
approved these changes
Sep 30, 2024
romange
pushed a commit
that referenced
this pull request
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes loading huge hmaps with TTL fields, where the TTL isn't parsed correctly:
This is caused by
kMaxBlobLennot being a multiple of 3. As eachLoadTracesegment contains elements key, value and TTL, when the segment is truncated, the next segment will be invalid. Such as it may start with 'value', 'ttl' instead of 'key', 'value', 'ttl', which leads to the above parsing error.Therefore when the map includes a TTL, each segment must be a multiple of 3.
(I guess a simpler alternative is just to set
kMaxBlobLento be a multiple of both 2 and 3? I'm not sure how important being a power of 2 is?)