Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add logs to test_acl_cat_commands_multi_exec_squash #3826

Merged
merged 1 commit into from
Sep 30, 2024
Merged

Conversation

kostasrim
Copy link
Contributor

@kostasrim kostasrim commented Sep 30, 2024

Add logs to test such that we know why it failed.

  • add logs

Helps with #3719

@kostasrim kostasrim changed the title fix: test_acl_cat_commands_multi_exec_squash [do not review] fix: test_acl_cat_commands_multi_exec_squash Sep 30, 2024
@kostasrim kostasrim changed the title [do not review] fix: test_acl_cat_commands_multi_exec_squash chore: add logs to test_acl_cat_commands_multi_exec_squash Sep 30, 2024
@kostasrim kostasrim requested a review from adiholden September 30, 2024 11:28
@kostasrim kostasrim self-assigned this Sep 30, 2024
@kostasrim
Copy link
Contributor Author

@adiholden I tried to reporudce here by running it 10k times but I could not make it fail. So I added an unconditional log. Hopefully it will fail again and we will know what happened

@kostasrim kostasrim enabled auto-merge (squash) September 30, 2024 11:46
@kostasrim kostasrim merged commit ec353e1 into main Sep 30, 2024
12 checks passed
@kostasrim kostasrim deleted the kpr1 branch September 30, 2024 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants