fix: Do not kill Dragonfly on failed DFLY LOAD
#3892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Today, some of the failures to load an RDB file passed via `--dbfilename` cause Dragonfly to terminate with an error code. This is ok and works as expected. The problem is that the same code path is used for `DFLY LOAD`, which means that if there's an error loading the file (such as corrupted file), Dragonfly will exit instead of returning an error code to the client. This change fixes that, by only exiting in the code path which loads on init. Note to reviewer: apparently we can't call `Future::Get()` more than once, as the first call resets the state of the future and drops the previously saved value, so we use a Fiber here instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today, some of the failures to load an RDB file passed via
--dbfilenamecause Dragonfly to terminate with an error code. This is ok and works as expected.The problem is that the same code path is used for
DFLY LOAD, which means that if there's an error loading the file (such as corrupted file), Dragonfly will exit instead of returning an error code to the client.This change fixes that, by only exiting in the code path which loads on init.
Note: failure to load an RDB will have meant that the entire data store was flushed (like with
FLUSHALL), so this is not an atomic operation.Note to reviewer: apparently we can't call
Future::Get()more than once, as the first call resets the state of the future and drops the previously saved value, so we use a Fiber here instead.