feat: introduce metrics/logs of when pipelining is being throttled #4000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romange
commented
Oct 26, 2024
src/facade/dragonfly_connection.cc
Outdated
| @@ -55,6 +55,10 @@ ABSL_FLAG(uint64_t, request_cache_limit, 64_MB, | |||
| ABSL_FLAG(uint64_t, pipeline_buffer_limit, 8_MB, | |||
| "Amount of memory to use for parsing pipeline requests - per IO thread."); | |||
|
|
|||
| ABSL_FLAG(uint32_t, pipeline_queue_limit, 1000, | |||
There was a problem hiding this comment.
just moved it here to be togheter with pipeline_buffer_limit
adiholden
reviewed
Oct 27, 2024
| @@ -52,8 +52,18 @@ ABSL_FLAG(string, admin_bind, "", | |||
| ABSL_FLAG(uint64_t, request_cache_limit, 64_MB, | |||
| "Amount of memory to use for request cache in bytes - per IO thread."); | |||
|
|
|||
| ABSL_FLAG(uint64_t, pipeline_buffer_limit, 8_MB, | |||
| "Amount of memory to use for parsing pipeline requests - per IO thread."); | |||
| ABSL_FLAG(uint64_t, pipeline_buffer_limit, 128_MB, | |||
There was a problem hiding this comment.
please make flag pipeline_buffer_limit mutable
adiholden
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3999 following up on discussion at #3997.