-
Notifications
You must be signed in to change notification settings - Fork 981
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(pre-commit): adds senstive data check like api keys #4030
Conversation
…check for cpp and py
.pre-commit-config.yaml
Outdated
hooks: | ||
- id: gitleaks | ||
|
||
- repo: https://github.com/jumanjihouse/pre-commit-hooks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we usually do not have shell scripts in our PRs. Is it really relevant to us?
.pre-commit-config.yaml
Outdated
rev: v1.3.5 | ||
hooks: | ||
- id: cpplint | ||
- repo: https://github.com/pylint-dev/pylint |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we use black
for py linting.
.pre-commit-config.yaml
Outdated
- repo: https://github.com/pocc/pre-commit-hooks | ||
rev: v1.3.5 | ||
hooks: | ||
- id: cpplint |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these checks are running locally, to my knowledge, not on github. Have you tried running them on our codebase?
fair enough I will remove them. |
Signed-off-by: BLANKatGITHUB <131886247+BLANKatGITHUB@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
This will check for sensitive data and linting problems before commit .
fix #4029