fix server: fix write to slowlog on squashing flow #4138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: adi_holden <adi@dragonflydb.io>
adiholden
commented
Nov 17, 2024
| @@ -1358,6 +1358,10 @@ bool Service::InvokeCmd(const CommandId* cid, CmdArgList tail_args, SinkReplyBui | |||
| // TODO: we should probably discard more commands here, | |||
| // not just the blocking ones | |||
| const auto* conn = cntx->conn(); | |||
| if (cntx->conn_state.squashing_info) { | |||
There was a problem hiding this comment.
what is the reason we dont save the connection pointer in cntx when running squashed commands?
There was a problem hiding this comment.
i dunno. maybe @dranikpg remembers.
|
how it affects slow invocations? in other words why conn pointer is relevant to slowlog? |
we have this condition conn != nullptr in which we do not enter the slowlog checks if conn is null. |
romange
approved these changes
Nov 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bug:
slow invocations where not written to slowlog
The fix:
extract the relevant connection pointer from context on squashing