fix: migration ACK response processing #4140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chakaz
reviewed
Nov 17, 2024
There was a problem hiding this comment.
I don't quite understand this fix.
With the fix, will attempt to read multiple times. But will we ever send multiple ACKs? I get that if it times out, we may want to try and read again (why not wait longer though?), but in which circumstance will we see more than 1 ACK? If previous ACKs are waiting? If that's the case, there could be other data waiting in line, no? (like regular journal)
|
@chakaz When get time out we don't know if the data is lost or delayed we try to resend ack but can get the previous response in this case we try to read one more time. In the main connection can't be other data, All other data is sent via flow connections |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
problem: the migration process can get stuck because of the pause between migration finalization attempts for #4081
fix: try reading the correct ACK response several times until timeout happens