Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: UB during cmd squashing reply size calculation #4149

Merged
merged 2 commits into from
Nov 19, 2024

Conversation

BorysTheDev
Copy link
Contributor

@BorysTheDev BorysTheDev commented Nov 19, 2024

address comments from #4147

@adiholden
Copy link
Collaborator

@BorysTheDev
please add the stats to PrintPrometheusMetrics
take pipeline_cmd_cache_bytes for example

@BorysTheDev BorysTheDev force-pushed the fix_reoky_size_calculation branch from 36325ae to 9fec36c Compare November 19, 2024 10:13
@BorysTheDev BorysTheDev merged commit 4e7800f into main Nov 19, 2024
12 checks passed
@BorysTheDev BorysTheDev deleted the fix_reoky_size_calculation branch November 19, 2024 11:40
romange pushed a commit that referenced this pull request Nov 23, 2024
* fix: UB during cmd squashing reply size calculation

* feat: add promtheus metric commands_squashing_replies_bytes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants