chore: allow slow and precise memory measurement of an object #4160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chakaz
reviewed
Nov 20, 2024
| @@ -291,7 +297,7 @@ static_assert(sizeof(CompactObj) == 18); | |||
|
|
|||
| namespace detail { | |||
|
|
|||
| size_t RobjWrapper::MallocUsed() const { | |||
| size_t RobjWrapper::MallocUsed(bool slow) const { | |||
There was a problem hiding this comment.
This works, but isn't very elegant. Why don't you want to cache this size on the object like we do elsewhere?
There was a problem hiding this comment.
I am planning to, once we switch to QList. Also with streams it may take some time as well.
Meanwhile I would like to have at least the "slow" variants because performance is not an issue for "memory usage".
Specifically fixes "MEMORY USAGE" for lists. Signed-off-by: Roman Gershman <roman@dragonflydb.io>
chakaz
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specifically fixes "MEMORY USAGE" for lists.
The
mi_collectcall may actually fix #3776 At least in my tests it stopped crashing.