Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: change the interface of stream and server commands #4219

Merged
merged 1 commit into from
Nov 28, 2024
Merged

Conversation

romange
Copy link
Collaborator

@romange romange commented Nov 28, 2024

No description provided.

@romange romange requested a review from kostasrim November 28, 2024 15:32
@romange romange enabled auto-merge (squash) November 28, 2024 15:47
Copy link
Contributor

@kostasrim kostasrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

void FlushAll(CmdArgList args, Transaction* tx, SinkReplyBuilder* builder,
ConnectionContext* cntx);
void Info(CmdArgList args, Transaction* tx, SinkReplyBuilder* builder, ConnectionContext* cntx)
void Auth(CmdArgList args, const CommandContext& cmd_cntx);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this 😄

@romange romange merged commit 010bd8a into main Nov 28, 2024
9 checks passed
@romange romange deleted the Pr1 branch November 28, 2024 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants