Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Hide replica info in real cluster if --managed_service_info #4241

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

chakaz
Copy link
Collaborator

@chakaz chakaz commented Dec 2, 2024

So far we only handled emulated cluster. This PR adds real cluster support.

Related to #4173

So far we only handled emulated cluster. This PR adds real cluster
support.

Related to #4173
@@ -815,6 +815,7 @@ void Service::Init(util::AcceptServer* acceptor, std::vector<facade::Listener*>
config_registry.RegisterMutable("replication_timeout");
config_registry.RegisterMutable("table_growth_margin");
config_registry.RegisterMutable("tcp_keepalive");
config_registry.RegisterMutable("managed_service_info");
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not think we should add all new flags here.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It helps with the test, but I guess that's not a good excuse to put here :)
On the other hand, I don't think there's a real risk / down side to it either

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll merge now, but if you'd like me to remove this please lmk

@chakaz chakaz merged commit b0d633f into main Dec 2, 2024
9 checks passed
@chakaz chakaz deleted the chakaz/managed-cluster-replica branch December 2, 2024 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants