Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: let resp parser provide more useful logs #4273

Merged
merged 2 commits into from
Dec 9, 2024
Merged

chore: let resp parser provide more useful logs #4273

merged 2 commits into from
Dec 9, 2024

Conversation

romange
Copy link
Collaborator

@romange romange commented Dec 7, 2024

  1. More warning logs around bad BAD_ARRAYLEN messages
  2. Lift the restriction around big bulk strings and log a warning instead.
  3. Pull helio

Probably fixes #4213

1. More warning logs around bad BAD_ARRAYLEN messages
2. Lift the restriction around big bulk strings and log a warning instead.
3. Pull helio

Signed-off-by: Roman Gershman <roman@dragonflydb.io>
@romange romange requested a review from chakaz December 7, 2024 19:44
chakaz
chakaz previously approved these changes Dec 8, 2024
Copy link
Collaborator

@chakaz chakaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG, but I'd add a unit test to parse such big inputs..

Probably fixes #4213

Signed-off-by: Roman Gershman <roman@dragonflydb.io>
@romange romange merged commit bf4f45a into main Dec 9, 2024
9 checks passed
@romange romange deleted the FixParser branch December 9, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

can't upload db by redis-cli --pipe
2 participants