feat(server): Support for LIMIT and REV in ZRANGE #422 #456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romange
reviewed
Nov 2, 2022
| @@ -1251,42 +1297,18 @@ void ZSetFamily::ZRangeByLex(CmdArgList args, ConnectionContext* cntx) { | |||
| return (*cntx)->SendError(kSyntaxErr); | |||
| string_view os = ArgS(args, 5); | |||
| string_view cs = ArgS(args, 6); | |||
| if (!SimpleAtoi(os, &count) || !SimpleAtoi(cs, &count)) { | |||
| if (!SimpleAtoi(os, &offset) || !SimpleAtoi(cs, &count)) { | |||
|
I made a mistake when handling parameters following the LIMIT group, the new commits should fix that |
dranikpg
reviewed
Nov 2, 2022
There was a problem hiding this comment.
Looks really solid! 🎩
It looks like ParseRangeByScoreParams has a similar issue. It doesn't allow inverse order: limit a b withscores. If possible, could you fix it as well? And add a test, that makes sure it works for both your command and deprecated ZRangeByScore
|
@RedhaL i pinged you at discord :) |
dranikpg
previously approved these changes
Nov 2, 2022
|
@dranikpg I just added the fix for zrangebyscore as well |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #422
Since the new ZRange regroups all the other (now deprecated) ZRange functions, I did some refactoring to avoid duplicating code from these functions. This made it possible to have support for ZRevRangeByLex for free, since the visitor function already supported it.
Also spotted and corrected an error in ZRangeByLex when parsing the offset parameter.
There are some unrelated formatting changes that were added by clang-format.