feat(tests): ioredis being able to successfully run tests, make it ready to be part of CI #459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lsvmello Thank you for your comments! please join our discord and say hello - I will add you to our #dev channel :) |
romange
reviewed
Nov 5, 2022
boazsade
force-pushed
the
ioredis-howto
branch
2 times, most recently
from
9cb17ef to
0229211
Compare
…ady to be part of CI Signed-off-by: Boaz Sade <boaz@dragonflydb.io>
boazsade
force-pushed
the
ioredis-howto
branch
from
0229211 to
05a1949
Compare
romange
approved these changes
Nov 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit do not include any changes in functionalities, but enable successfully running ioredis tests
Please note that since ioredis has coverage for features that we are not supporting yet, using the script to run it on the container is the safest way to currently execute these tests right now. Also as we add more features, these scripts need to be updated accordingly.