feat(server): adding matrices for memory defrag #535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romange
reviewed
Dec 6, 2022
src/server/server_family.cc
Outdated
| @@ -1304,6 +1305,8 @@ void ServerFamily::Info(CmdArgList args, ConnectionContext* cntx) { | |||
| append("total_writes_processed", m.conn_stats.io_write_cnt); | |||
| append("async_writes_count", m.conn_stats.async_writes_cnt); | |||
| append("parser_err_count", m.conn_stats.parser_err_cnt); | |||
| append("defragmentations_tries_total", m.defrag_stats.tries); | |||
| append("defragmented_addresses_total", m.defrag_stats.success_count); | |||
There was a problem hiding this comment.
some renaming:
defragmentations_tries_total -> defrag_attempt_total
defragmented_addresses_total -> defrag_realloc_total
romange
reviewed
Dec 6, 2022
src/server/server_family.h
Outdated
| @@ -35,6 +35,7 @@ struct Metrics { | |||
| SliceEvents events; | |||
| TieredStats tiered_stats; | |||
| EngineShard::Stats shard_stats; | |||
| EngineShard::DefragStats defrag_stats; | |||
There was a problem hiding this comment.
I do not see why it should be separate from EngineShard::Stats, I would move it there since these are part of the shard stats
There was a problem hiding this comment.
remove this type completely (it would require small change in unit test as well).
Signed-off-by: Boaz Sade <boaz@dragonflydb.io>
boazsade
force-pushed
the
active-mem-derag-stats
branch
from
c0584a4 to
00540b5
Compare
romange
approved these changes
Dec 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Boaz Sade boaz@dragonflydb.io
Add metrics for the memory defragmentation.
This see this run the command "info stats"
Two new entries:
defrag_attempt_total - the total number of times that the stasks (for all shards) checked memory for possible defragmentation
defrag_realloc_total - the total number of pointers (from all shards) that were moved dues defragmentation