Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added example of start script #557

Merged
merged 2 commits into from
Dec 11, 2022
Merged

added example of start script #557

merged 2 commits into from
Dec 11, 2022

Conversation

Tomato6966
Copy link
Contributor

@Tomato6966 Tomato6966 commented Dec 11, 2022

  • removed duplicated explanation

Signed-off-by: Tomato6966

+ removed duplicated explanation

Signed-off-by: Tomato6966 <chris.pre03@gmail.com>
README.md Outdated
### Example Start Script, with all options:

```bash
./dragonfly-x86_64 --logtostderr --requirepass=youshallnotpass --cache_mode=true -dbnum 1 --bind localhost --port 5555 --hz=100 --save_schedule "*:30" --maxmemory=12gb --keys_output_limit=12288 --dbfilename dump.rdb
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @Tomato6966 .

no problem to add an example but I would like to do the following fixes:

  1. with all options -> with popular options
  2. Please remove --hz option, I prefer avoid advertising it, specially because we improved the CPU around it.
  3. Please change to --port=6379 so it will be consistent with the default port of Redis.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@romange I did the update

Signed-off-by: Tomato6966 <chris.pre03@gmail.com>
@romange romange merged commit 0efa1c9 into dragonflydb:main Dec 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants