Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(server): adding version monitoring task #586

Merged
merged 1 commit into from
Dec 25, 2022

Conversation

boazsade
Copy link
Contributor

@boazsade boazsade commented Dec 21, 2022

Fixes issue #558
A task that monitors the version from a remote endpoint.
This would print a message in case we have mismatch between the local version and the remote version.
In case we are running in dev build, this task will not run.
Signed-off-by: Boaz Sade boaz@dragonflydb.io

src/server/dfly_main.cc Outdated Show resolved Hide resolved
src/server/dfly_main.cc Outdated Show resolved Hide resolved
src/server/dfly_main.cc Outdated Show resolved Hide resolved
src/server/dfly_main.cc Outdated Show resolved Hide resolved
src/server/dfly_main.cc Outdated Show resolved Hide resolved
@boazsade boazsade force-pushed the monitor-remote-version branch from 79ed892 to 9355eab Compare December 21, 2022 17:06
src/server/dfly_main.cc Outdated Show resolved Hide resolved
src/server/dfly_main.cc Outdated Show resolved Hide resolved
Copy link
Collaborator

@romange romange left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

getting there

@boazsade boazsade force-pushed the monitor-remote-version branch from 9355eab to 22dcd0c Compare December 22, 2022 05:31
src/server/dfly_main.cc Outdated Show resolved Hide resolved
src/server/dfly_main.cc Outdated Show resolved Hide resolved
@boazsade boazsade force-pushed the monitor-remote-version branch from 22dcd0c to 57e4bb9 Compare December 22, 2022 07:31
Signed-off-by: Boaz Sade <boaz@dragonflydb.io>
@boazsade boazsade force-pushed the monitor-remote-version branch from 57e4bb9 to 58caeb6 Compare December 22, 2022 09:59
@boazsade boazsade merged commit 8d86e9b into dragonflydb:main Dec 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants