feat(server): Add metrics #638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please note the naming conventions for prometheus:
https://prometheus.io/docs/practices/naming/
specifically add _total to hits and misses imho.
Also, pls change the commit description to has "Fixes #..." to link it to
the issue.
…On Tue, Jan 3, 2023 at 5:09 PM ashotland ***@***.***> wrote:
@ashotland <https://github.com/ashotland> requested your review on: #638
<#638> chore(server): Add
metrics.
—
Reply to this email directly, view it on GitHub
<#638 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA4BFCCYODC4WRDUUVGCA73WQQ6K5ANCNFSM6AAAAAATPZDUMU>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
romange
reviewed
Jan 3, 2023
romange
reviewed
Jan 3, 2023
ashotland
commented
Jan 3, 2023
|
You should setup your presubmit checks - you have trailing whitespace in the commit. besides that- LGTM. And update the commit with "Fixes #..." |
ashotland
force-pushed
the
metrics
branch
2 times, most recently
from
284d767 to
06128d7
Compare
Signed-off-by: ashotland <ashotland@gmail.com> Fixes #637
romange
approved these changes
Jan 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: ashotland ashotland@gmail.com
Fixes #637
Added: