test(replication_test) : add replica flushall test #669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: adi_holden <adi@dragonflydb.io>
Signed-off-by: adi_holden <adi@dragonflydb.io>
dranikpg
requested changes
Jan 12, 2023
tests/dragonfly/replication_test.py
Outdated
| Check replica keys at the end. | ||
| """ | ||
|
|
||
| @dfly_args({"logtostdout":"", "vmodule":"replica=2"}) |
There was a problem hiding this comment.
Please remove this, if you need this when running, you can do pytest ... --df logtostdout --df vmodule=replica=2
tests/dragonfly/replication_test.py
Outdated
Comment on lines
342
to
343
| for i in range(n_keys): | ||
| pipe.mset({f"{i}": "v", f"{i+1}": "v"}) |
There was a problem hiding this comment.
You set all the keys twice, or is this intended? You can use range(step=2) to skip over one
Besides, I have also utils.chunked() that can split an iterable into chunks, so you can use mset with a generic number of keys. Probably not needed here as you start them with 4/2 threads
Signed-off-by: adi_holden <adi@dragonflydb.io>
dranikpg
approved these changes
Jan 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: adi_holden adi@dragonflydb.io