feat(server): Json rdb support #674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vladislav Oleshko <vlad@dragonflydb.io>
dranikpg
commented
Jan 13, 2023
Comment on lines
+543
to
+546
| error_code RdbSerializer::SaveJsonObject(const PrimeValue& pv) { | ||
| auto json_string = pv.GetJson()->to_string(); | ||
| return SaveString(json_string); | ||
| } |
There was a problem hiding this comment.
In the future we should maybe enable one of jsoncons extensions and use a binary format like bson
romange
approved these changes
Jan 14, 2023
| @@ -64,6 +65,7 @@ class ValueType(Enum): | |||
| SET = 2 | |||
| HSET = 3 | |||
| ZSET = 4 | |||
| JSON = 5 | |||
There was a problem hiding this comment.
Those are class fields - pythonic way to make an enum. Better than making it all just global flags
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #587