Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(rdb): Add json dump & restore test #678

Merged
merged 2 commits into from
Jan 15, 2023
Merged

test(rdb): Add json dump & restore test #678

merged 2 commits into from
Jan 15, 2023

Conversation

dranikpg
Copy link
Contributor

Forgot to add this

@dranikpg
test(rdb): Add json dump & restore test
9b67107 
Signed-off-by: Vladislav Oleshko <vlad@dragonflydb.io>
romange
romange reviewed Jan 14, 2023
View reviewed changes
src/server/rdb_test.cc Outdated Show resolved Hide resolved
romange
romange reviewed Jan 14, 2023
View reviewed changes
Copy link
Collaborator

@romange romange left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dranikpg
fix(tests): Use assert
cb2926e 
Signed-off-by: Vladislav Oleshko <vlad@dragonflydb.io>
@dranikpg dranikpg requested a review from romange January 14, 2023 20:52
@dranikpg dranikpg merged commit 7b7e3ea into dragonflydb:main Jan 15, 2023
@dranikpg dranikpg deleted the json-test branch February 27, 2023 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romange romange romange approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dranikpg @romange